Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and clarify JupyterHub README #616

Merged
merged 2 commits into from Apr 9, 2018

Conversation

willingc
Copy link
Contributor

@willingc willingc commented Apr 8, 2018

  • Update information about JupyterHub and its configuration
  • Reflow format text sections with changes

This change is Reviewable

@pdmack
Copy link
Member

pdmack commented Apr 9, 2018

/ok-to-test

@willingc
Copy link
Contributor Author

willingc commented Apr 9, 2018

Minikube test failure seems unrelated to this PR.

@pdmack
Copy link
Member

pdmack commented Apr 9, 2018

/retest

@pdmack
Copy link
Member

pdmack commented Apr 9, 2018

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pdmack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 339b55d into kubeflow:master Apr 9, 2018
@willingc willingc deleted the readme-steps branch April 9, 2018 20:39
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* Update and clarify JupyterHub README

* minor grammar edit
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
Set trial completion status only after metric collection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants