Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug of ResourceQuota removal #6188

Merged

Conversation

sunzhaochang
Copy link
Contributor

Fix #6187

@google-cla google-cla bot added the cla: yes label Oct 14, 2021
@aws-kf-ci-bot
Copy link

Hi @sunzhaochang. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign stefanofioravanzo after the PR has been reviewed.
You can assign the PR to them by writing /assign @stefanofioravanzo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sunzhaochang
Copy link
Contributor Author

@kimwnasptd Could you please take a look at this PR ? Thanks.

@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Mar 2, 2022
@stale stale bot closed this Apr 16, 2022
@sunzhaochang
Copy link
Contributor Author

/reopen

@google-oss-prow google-oss-prow bot reopened this Jul 25, 2022
@google-oss-prow
Copy link

@sunzhaochang: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sergeyshevch
Copy link

@kimwnasptd @StefanoFioravanzo Can someone look at this? It's a really little fix that can be easily reviewed. I also faced with the bug that will be fixed by this PR

@kimwnasptd
Copy link
Member

This got completely out of my radar, thanks for the ping @sergeyshevch.

The changes look good. This is also a small fix that we could include in the next KF 1.7 RC cc @DomFleischmann

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1552c90 into kubeflow:master Feb 8, 2023
kimwnasptd pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2023
google-oss-prow bot pushed a commit that referenced this pull request Feb 15, 2023
Co-authored-by: sunboy <zhchsun1992@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ResourceQuota still exists after removed from profile
5 participants