Improve user guide wrt exposing notebook in non-cloud setup #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
/ok-to-test |
This makes it more clear how to expose the Jupyter notebook if you are on a standalone node without loadbalancer access.
xyhuang
force-pushed
the
bug-user-guide-fix
branch
from
8242157
to
7a17021
Compare
|
CLAs look good, thanks! |
pdmack
suggested changes
Apr 10, 2018
user_guide.md
Outdated
| @@ -170,9 +170,23 @@ tf-hub-lb ClusterIP 10.11.245.94 <none> 80/TCP 1 | |||
| ... | |||
| ``` | |||
|
|
|||
| By default we are using ClusterIPs for the JupyterHub UI. This can be changed to a LoadBalancer by issuing `ks param set kubeflow-core jupyterHubServiceType LoadBalancer`, however this will leave your Jupyter Notebook open to the Internet. | |||
| By default we are using ClusterIPs for the JupyterHub UI. This can be changed to one of the followings: | |||
user_guide.md
Outdated
| ks apply ${KF_ENV} | ||
| ``` | ||
|
|
||
| however this will leave your Jupyter Notebook open to the Internet. |
|
/retest |
1 similar comment
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pdmack The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
…#625) * Improve user guide wrt exposing notebook in non-cloud setup This makes it more clear how to expose the Jupyter notebook if you are on a standalone node without loadbalancer access. * Minor fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it more clear how to expose the Jupyter notebook if you are
on a standalone, non-cloud node.
This change is