New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstraper polish: #654
Bootstraper polish: #654
Conversation
1. Use namespace pass in argument (--namespace=) or defalut namespace ('kubeflow'), create it if not exists. 2. Add unit test pkg (github.com/stretchr/testify) to gilde. 3. Edit Makefile for macOS compatibility
Review status: 0 of 124 files reviewed at latest revision, all discussions resolved. bootstrap/cmd/bootstrap/app/server.go, line 181 at r1 (raw file):
nit; "Using namespace: " Any reason to use fmt here and not log? Comments from Reviewable |
@jlewi sorry, this line was for testing only, now removed. |
/assign @jlewi |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
* Bootstraper polish: 1. Use namespace pass in argument (--namespace=) or defalut namespace ('kubeflow'), create it if not exists. 2. Add unit test pkg (github.com/stretchr/testify) to gilde. 3. Edit Makefile for macOS compatibility * rm debug output * undo change, will handle in separate PR
create it if not exists.
This change is