release: Use DockerHub for all images #6548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that the above PR failed for 2 reasons:
|
@apo-ger had worked on updating all the Makefiles and also revamped the build process of the notebook-servers. But since we are tight on time I'll just revert the dockerhub change in the Dockerfiles of the notebooks, for the build process to success. But to fix this properly we must rework on the problematic build process of the notebook servers. @apo-ger let's do this after the RC0 is cut
@NickLoukas has a PR for this in flight #6549 |
kimwnasptd
force-pushed
the
feature-kimwnasptd-1-6-pre-release
branch
from
d1496ba
to
639cbee
Compare
The GH Actions will pick up the change in releasing/version/VERSION and rebuild all the images. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
We'll need to have proper makefiles for building these images and not expect the base images to be already committed. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
kimwnasptd
force-pushed
the
feature-kimwnasptd-1-6-pre-release
branch
from
67572a1
to
0664424
Compare
|
@elikatsis @StefanoFioravanzo @thesuperzapper this should be ready to merge. All tests pass, images can be build and manifests get applied in a K8s 1.22 cluster successfully |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: StefanoFioravanzo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
apo-ger
pushed a commit
to apo-ger/kubeflow
that referenced
this pull request
Dec 8, 2022
* release: Update the tag to v1.6.0-alpha and reubild images The GH Actions will pick up the change in releasing/version/VERSION and rebuild all the images. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * Update all images to use DockerHub Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Reuse ECR images as base We'll need to have proper makefiles for building these images and not expect the base images to be already committed. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * releasing: Update releasing script for dockerhub Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * release: Update manifests for v1.6.0-rc.0 Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
This was referenced Dec 8, 2022
apo-ger
pushed a commit
to apo-ger/kubeflow
that referenced
this pull request
Dec 8, 2022
* Update the tag to v1.6.0-alpha
* Update all images to use DockerHub
* notebooks: Reuse ECR images as base
- We'll need to have proper makefiles for building these images and not
expect the base images to be already committed.
* Update releasing script for dockerhub
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Cherry-picked-from: kubeflow#6548
apo-ger
pushed a commit
to apo-ger/kubeflow
that referenced
this pull request
Dec 8, 2022
cherry-picking: kubeflow#6548 * Update all images to use DockerHub * Update releasing script for dockerhub Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Cherry-picked-by: Apostolos Gerakaris <apoger@arrikto.com>
google-oss-prow bot
pushed a commit
that referenced
this pull request
Dec 8, 2022
cherry-picking: #6548 * Update all images to use DockerHub * Update releasing script for dockerhub Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Cherry-picked-by: Apostolos Gerakaris <apoger@arrikto.com> Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> Co-authored-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
3 tasks
harshad16
pushed a commit
to harshad16/odh-kubeflow
that referenced
this pull request
Oct 5, 2023
* release: Update the tag to v1.6.0-alpha and reubild images The GH Actions will pick up the change in releasing/version/VERSION and rebuild all the images. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * Update all images to use DockerHub Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * notebooks: Reuse ECR images as base We'll need to have proper makefiles for building these images and not expect the base images to be already committed. Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * releasing: Update releasing script for dockerhub Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * release: Update manifests for v1.6.0-rc.0 Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm making the PR for the
v1.6-branchinitially and we can cherry-pick tomasterlater on.This PR:
docker.io/kubeflownotebookswgreleasing/version/VERSIONfile to build all images with the tagv1.6.0-alpha, to ensure all images can be build/git cc @elikatsis @StefanoFioravanzo @thesuperzapper