Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure] Jupyter spawner: driver volumes for azure #655

Merged
merged 4 commits into from Apr 18, 2018

Conversation

wbuchwalter
Copy link
Contributor

@wbuchwalter wbuchwalter commented Apr 13, 2018

Fix #435
Currently Azure does not use device plugins, so the NVIDIA drivers need to be mounted for GPUs to work.
This is meant to be a temporary fix and will be removed as soon as AKS supports device-plugin.

cc @willingc


This change is Reviewable

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks reasonable to me. I'm not sure why the tests are failing.

@wbuchwalter
Copy link
Contributor Author

/retest

@wbuchwalter
Copy link
Contributor Author

wbuchwalter commented Apr 17, 2018

/retest (last failure was only on minikube and seems like a flake)

@wbuchwalter
Copy link
Contributor Author

/assign @jlewi @ankushagarwal
Could one of you take a loot ?

@jlewi
Copy link
Contributor

jlewi commented Apr 18, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bcf0698 into master Apr 18, 2018
@gaocegege gaocegege deleted the jupyter-hub-azure branch June 18, 2018 12:48
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* jupyter spawner: driver volumes for azure

* add cloud param jupyter libsonnet test

* fix jupyter libsonnet test
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
* Add permissions to JWA for SubjectAccessReviews

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Add jwa tests only

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Jupyter/Azure] Drivers are not mounted when spawning a JupyterHub with GPU
5 participants