New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure] Jupyter spawner: driver volumes for azure #655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks reasonable to me. I'm not sure why the tests are failing.
/retest |
/retest (last failure was only on minikube and seems like a flake) |
/assign @jlewi @ankushagarwal |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* jupyter spawner: driver volumes for azure * add cloud param jupyter libsonnet test * fix jupyter libsonnet test
* Add permissions to JWA for SubjectAccessReviews Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * Add jwa tests only Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Fix #435
Currently Azure does not use device plugins, so the NVIDIA drivers need to be mounted for GPUs to work.
This is meant to be a temporary fix and will be removed as soon as AKS supports device-plugin.
cc @willingc
This change is