Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web-apps: Ensure in-flight requests are cancelled #6718

Merged
merged 8 commits into from
Nov 10, 2022
Merged

web-apps: Ensure in-flight requests are cancelled #6718

merged 8 commits into from
Nov 10, 2022

Commits on Nov 8, 2022

  1. vwa(front): Use ng serve for local dev 

    Add proxy rules to connect the webpack dev server with the backend
    @kimwnasptd
    kimwnasptd committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    48211ef View commit details
    Browse the repository at this point in the history

  2. twa(front): Use ng serve for local dev 

    Refs arrikto/dev#1597
    @kimwnasptd
    kimwnasptd committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    9d8d76e View commit details
    Browse the repository at this point in the history

  3. vwa(back): Fix the install-deps make rule 

    Use the new common code path when installing the common packages.
    @kimwnasptd
    kimwnasptd committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    bc7b630 View commit details
    Browse the repository at this point in the history

  4. wa(front): Disable Angular analytics 

    Edit the angular.json file of all our frontend components to not send
Angular analytics. This way we won't be seeing a y/N input each time we
try to build the frontend, which could also block a CI/CD system.
    @kimwnasptd
    kimwnasptd committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    fb526cb View commit details
    Browse the repository at this point in the history

  5. wa(front): Add exponential-backoff service 

    Create an Angular Service that handles the polling. Specifically the
polling function has as input an observable responsible for fetching the
data. It will return a final observable, which will be using the
fetch-observable, that will only be emitting the final data.

This service will take care of:
1. Checking if the new data is new and reset the polling
2. Cancelling in-flight requests, if someone terminates the subscription
    @kimwnasptd
    kimwnasptd committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    aa3c533 View commit details
    Browse the repository at this point in the history

  6. vwa(front): Use the new Polling Service 

    The frontend code of VWA will now be using the new Poller Service which
has a pure RxJS implementation underneath. This will make it simpler to
cancel in-flight requests and also moves the reset logic into the common
code.
    @kimwnasptd
    kimwnasptd committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    5f5e327 View commit details
    Browse the repository at this point in the history

  7. jwa(front): Use the new Polling Service 

    The frontend code of JWA will now be using the new Poller Service which
has a pure RxJS implementation underneath. This will make it simpler to
cancel in-flight requests and also moves the reset logic into the common
code.
    @kimwnasptd
    kimwnasptd committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    118f434 View commit details
    Browse the repository at this point in the history

  8. twa(front): Use the new Polling Service 

    The frontend code of TWA will now be using the new Poller Service which
has a pure RxJS implementation underneath. This will make it simpler to
cancel in-flight requests and also moves the reset logic into the common
code.
    @kimwnasptd
    kimwnasptd committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    170b5a3 View commit details
    Browse the repository at this point in the history