jwa: Add EVENTS tab to Notebook details page #6782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add logic in the backend to fetch the events of a notebook. - Fix the authorization parameters in the get_notebook_events function. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Add Events tab to show the available events of the notebook in the form of a table, in order to help a user with debugging the notebook. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
orfeas-k
force-pushed
the
feature-orfeas-jwa-details-page-events-tab
branch
from
e89a6d5
to
5c1acc5
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
maroroman
pushed a commit
to maroroman/kubeflow
that referenced
this pull request
Feb 7, 2023
* jwa(back): Get a notebook's events - Add logic in the backend to fetch the events of a notebook. - Fix the authorization parameters in the get_notebook_events function. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com> * jwa(front): Add EVENTS tab to Notebook details page Add Events tab to show the available events of the notebook in the form of a table, in order to help a user with debugging the notebook. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com> Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an EVENTS tab to the new JWA details page. It is part of the Details page for each Notebooks/Volumes/TensorBoards effort and a follow-up PR to this. The goal of this tab is to present
Eventsas we view them withkubectl describe notebook <notebook-name> -n <namespace>.