create rolebinding within namespace to guarantee permission #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @jlewi |
jlewi
reviewed
Apr 19, 2018
| @@ -201,6 +205,19 @@ func Run(opt *options.ServerOption) error { | |||
| return err | |||
| } | |||
|
|
|||
| log.Infof("create rolebinding kubeflow-admin for role permission") | |||
There was a problem hiding this comment.
Any particular reason we're shelling out to kubectl rather than using the goclient to make a request to the API?
| @@ -201,6 +205,19 @@ func Run(opt *options.ServerOption) error { | |||
| return err | |||
| } | |||
|
|
|||
| log.Infof("create rolebinding kubeflow-admin for role permission") | |||
| user, err := exec.Command("gcloud", "config", "get-value", "account").Output() | |||
There was a problem hiding this comment.
We shouldn't be running gcloud commands unless we are using GKE. You can use the isGke function to check.
|
/assign @ankushagarwal |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankushagarwal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
…#680) * create rolebinding within namespace to guarantee permission * Check if kubernetes on GKE before create rolebinding, and update README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is