Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jwa(front): Fix unit tests #6804

Merged
merged 11 commits into from Dec 7, 2022
Merged

jwa(front): Fix unit tests #6804

merged 11 commits into from Dec 7, 2022

Conversation

elenzio9
Copy link
Contributor

@elenzio9 elenzio9 commented Dec 5, 2022

This PR fixes JWA's unit tests.

@elenzio9
jwa(front): Rename form-default component
f846351 
Signed-off-by: Elena Zioga <elena@arrikto.com>
@elenzio9
jwa(front): Create missing module files
db2a248 
Signed-off-by: Elena Zioga <elena@arrikto.com>
@elenzio9
jwa(front): Remove form-rok and form components
5e09b0e 
Signed-off-by: Elena Zioga <elena@arrikto.com>
@elenzio9
jwa(front): Update JWA's @angular/common package
4bf851f 
Signed-off-by: Elena Zioga <elena@arrikto.com>
@elenzio9
jwa(front): Modify rok-url component
6e5378f 
Signed-off-by: Elena Zioga <elena@arrikto.com>
@elenzio9
web-apps(front): Add Rok URL message
e98e68a 
Signed-off-by: Elena Zioga <elena@arrikto.com>
@elenzio9
vwa(front): Update VWA's @angular/common package
e00a8a3 
Signed-off-by: Elena Zioga <elena@arrikto.com>
@elenzio9
vwa(front): Remove the headers request
d8c6f37 
Remove the headers request since the common code implements it.

Signed-off-by: Elena Zioga <elena@arrikto.com>
@elenzio9
jwa(front): Fix JWA's unit tests
5cf632e 
Fix JWA's unit tests.

Signed-off-by: Elena Zioga <elena@arrikto.com>
@kimwnasptd
Copy link
Member

This is a great effort! Let's have a dedicated .github/jwa_frontend_tests.yaml file and run the unit tests on each change of the code in the frontend code of the web app

@elenzio9
gh-actions: Add GH action to run JWA unit tests
40a77c7 
Signed-off-by: Elena Zioga <elena@arrikto.com>
@elenzio9
jwa(build): Update Dockerfile
775bae9 
Update Dockerfile to not build Rok.

Signed-off-by: Elena Zioga <elena@arrikto.com>
@elenzio9
Copy link
Contributor Author

elenzio9 commented Dec 7, 2022

This is a great effort! Let's have a dedicated .github/jwa_frontend_tests.yaml file and run the unit tests on each change of the code in the frontend code of the web app

@kimwnasptd I added a github action that will run jwa's unit tests on every change to the app's frontend code. Please take a look!

@kimwnasptd
Copy link
Member

Thanks!

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Dec 7, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 539f497 into kubeflow:master Dec 7, 2022
@kimwnasptd kimwnasptd mentioned this pull request Feb 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elikatsis elikatsis Awaiting requested review from elikatsis

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

Assignees

@kimwnasptd kimwnasptd

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elenzio9 @kimwnasptd