jwa(front): Link to VWA details page #6857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 16, 2022 12:43
Create a URLs component in Kubeflow common library which takes a list of URLs and their corresponding name and exposes them horizontally in a div. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Add a unit test for lib-urls component Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Remove Volumes column from the table in JWA's index page. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
- Expose all volumes from a notebook, not only PVCs. - Expose the volumes grouped by type, having PVCs link to their corresponding volume details page in VWA, using lib-urls component. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Implement lib-urls component in the OVERVIEW tab of VWA's volume details page to avoid duplicate code. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Use common link styles in configurations component. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
orfeas-k
force-pushed
the
feature-orfeas-jwa-details-page-link-to-vwa
branch
from
02c4c1d
to
0671d7a
Compare
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
orfeas-k
force-pushed
the
feature-orfeas-jwa-details-page-link-to-vwa
branch
from
0671d7a
to
6d37f53
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about the effort to link to VWA volumes details page from the volumes row in JWA notebook details page.
In detail:
Here is a screenshot with the final implementation