Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce workflows for building notebook-server images upon changes #6898

Conversation

apo-ger
Copy link
Contributor

@apo-ger apo-ger commented Jan 18, 2023

This PR resolves part of: #6766

Introduce GitHub Action workflows for testing that notebook server images can be built for each PR.

@apo-ger apo-ger force-pushed the feature-apoger-gh-actions-test-notebook-server-images branch from 8d472c9 to 6a24d7c Compare February 16, 2023 13:31
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@apo-ger apo-ger force-pushed the feature-apoger-gh-actions-test-notebook-server-images branch from 6a24d7c to 80d96cd Compare February 16, 2023 13:46
@kimwnasptd
Copy link
Member

@apo-ger the changes look good. Only have one suggestion; should we also trigger these when the releasing/version/VERSION file changes? Right now IIUC these workflows won't run once we update the manifests for a new release #6975

@apo-ger apo-ger force-pushed the feature-apoger-gh-actions-test-notebook-server-images branch from 80d96cd to 5c29ca4 Compare February 17, 2023 13:51
@apo-ger
Copy link
Contributor Author

apo-ger commented Feb 17, 2023

@kimwnasptd Yes you are right, I updated the PR.

@thesuperzapper
Copy link
Member

This was fixed as part of #7357.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants