Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: Introduce a PVCViewer Controller in Kubeflow #6941

Conversation

apo-ger
Copy link
Contributor

@apo-ger apo-ger commented Feb 7, 2023

Provide a design doc as a proposal for introducing a PVCViewer Controller in Kubeflow. PVCViewers enable users to open a web app UI on arbitrary persistent volume claims, letting them inspect, download, upload and manipulate data.

Our proposal is in markdown format and follows the guidelines of the kubeflow/components/proposal/README.md guide.

On-going effort: #6876

Provide a design doc as a proposal for introducing a PVCViewer
Controller in Kubeflow. PVCViewers enable users to open a web app
UI on arbitrary persistent volume claims, letting them inspect,
download, upload and manipulate data.

Our proposal is in markdown format and follows
the guidelines of the kubeflow/components/proposal/README.md guide.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
@apo-ger
Copy link
Contributor Author

apo-ger commented Feb 7, 2023

cc @kimwnasptd

@kimwnasptd
Copy link
Member

Thanks @apo-ger! Will take a more detailed look by EOW

/cc @TobiasGoerke

@google-oss-prow
Copy link

@kimwnasptd: GitHub didn't allow me to request PR reviews from the following users: TobiasGoerke.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Thanks @apo-ger! Will take a more detailed look by EOW

/cc @TobiasGoerke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TobiasGoerke
Copy link
Contributor

Thanks, @apo-ger! I'm currently on vacation and only able to read this on my mobile but from what I've read this looks very good to me! My only remark: I'm still unsure about whether a restart functionality makes sense or is required, so we might need to evaluate this in a future iteration.

@kimwnasptd
Copy link
Member

I think we can go on and merge this PR, considering that we've had a lot of back and forth on this and in the initial gdoc.

Thanks for your efforts on this @apo-ger @TobiasGoerke!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 80cfd25 into kubeflow:master May 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants