New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
centraldashboard: Support dynamic logout URL #6945
centraldashboard: Support dynamic logout URL #6945
Conversation
Use dynamic URL for the logout button that can be set by the LOGOUT_URL ENV variable in the deployment of the app. If it is unset, a default '/logout' string is passed from the backend to the frontend. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
e105b76
to
9772882
Compare
9772882
to
9356553
Compare
Sure, I also removed the tests commit from this PR |
@orfeas-k tested the PR and while the logout works, I end up seeing a blank screen. Navigating back to the root URL gets me to login, so the logout functionality works, but I think something might not be configured correctly on the AuthService's side. I'll look more into it with @athamark. @DomFleischmann there's a chance we'll need some fix for this, but we'll comment back once we have more news |
I'll go on and merge this for now to include this in the RC1 /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Use dynamic URL for the logout button that can be set by the LOGOUT_URL ENV variable in the deployment of the app. If it is unset, a default '/logout' string is passed from the backend to the frontend. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Use dynamic URL for the logout button that can be set by the LOGOUT_URL ENV variable in the deployment of the app. If it is unset, a default '/logout' string is passed from the backend to the frontend. Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com> Co-authored-by: Orfeas Kourkakis <orfeas@arrikto.com>
Use dynamic URL for the logout button that can be set by the
LOGOUT_URL
ENV variable in the deployment of the app. If it is unset, a default '/logout' string is passed from the backend to the frontend.I documented in the issue here details on how I dealt with binding data between Polymer elements.
During this PR, we also had to fix a test that was broken. It seems that the test was failing because
new Date ()
added whitespace that was not equal to the space character during comparison. Instead of comparing objects of typeDate
andstring
in the expect statement, we went with comparingDate
objects in order to ensure comparison in a uniform and type-strict way.