centraldashboard: Allow all-namespaces option for kwa #6958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-oss-prow
bot
requested review from
kimwnasptd,
SachinVarghese and
yanniszark
elenzio9
force-pushed
the
feature-elena-all-namespaces-for-kwa-mwa
branch
from
d0f8434
to
282d68a
Compare
elenzio9
force-pushed
the
feature-elena-all-namespaces-for-kwa-mwa
branch
from
282d68a
to
adc18cc
Compare
elenzio9
changed the title
|
Built the image and tested on my cluster. It works as expected, thank you @elenzio9! This should always be merged after this one in KWA in order for the All namespaces feature to be functional there. |
Enable all-namespace support in KWA by displaying the "All namespaces" option in the dashboard. Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9
force-pushed
the
feature-elena-all-namespaces-for-kwa-mwa
branch
from
adc18cc
to
0a47c24
Compare
|
merging this, since the all-namespaces support is integrated in the Katib web app kubeflow/katib#2119 /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we enable all-namespace support in KWA by displaying the
All namespacesoption in the dashboard.Related PR: kubeflow/katib#2119