jwa: Remove all the Rok references #6985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenzio9
changed the title
tasos-ale
suggested changes
Feb 28, 2023
| * Custom command to mock requests at | ||
| * - '/api/storageclasses' | ||
| * - '/api/rok/storageclasses' | ||
| * Custom command to mock requests at - '/api/storageclasses' |
There was a problem hiding this comment.
Suggested change
| * Custom command to mock requests at - '/api/storageclasses' | |
| * Custom command to mock requests at '/api/storageclasses' |
elenzio9
force-pushed
the
feature-elena-jwa-remove-rok-references
branch
from
9b82c82
to
49d75a7
Compare
Right! I just removed them. |
Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9
force-pushed
the
feature-elena-jwa-remove-rok-references
branch
from
49d75a7
to
8252b92
Compare
tasos-ale
approved these changes
Feb 28, 2023
|
/lgtm |
|
/approve |
|
@kimwnasptd I believe we can merge this PR. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd, tasos-ale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
* jwa(front): Remove rok references Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(back): Remove rok references Signed-off-by: Elena Zioga <elena@arrikto.com> --------- Signed-off-by: Elena Zioga <elena@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
* jwa(front): Remove rok references Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(back): Remove rok references Signed-off-by: Elena Zioga <elena@arrikto.com> --------- Signed-off-by: Elena Zioga <elena@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
* jwa(front): Remove rok references Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(back): Remove rok references Signed-off-by: Elena Zioga <elena@arrikto.com> --------- Signed-off-by: Elena Zioga <elena@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 23, 2024
* jwa(front): Remove rok references Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(back): Remove rok references Signed-off-by: Elena Zioga <elena@arrikto.com> --------- Signed-off-by: Elena Zioga <elena@arrikto.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 23, 2024
* jwa(front): Remove rok references Signed-off-by: Elena Zioga <elena@arrikto.com> * jwa(back): Remove rok references Signed-off-by: Elena Zioga <elena@arrikto.com> --------- Signed-off-by: Elena Zioga <elena@arrikto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all the Rok references from JWA's code.