Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile-controller: Support custom cluster domain other than cluster.local #7016

Conversation

avintonOfficial
Copy link
Contributor

profile controller does not work on the clusters which have a custom cluster domain because of the hardcoded "Principals".

Original code:

				From: []*istioSecurity.Rule_From{
					{
						Source: &istioSecurity.Source{
							Principals: []string{"cluster.local/ns/kubeflow/sa/notebook-controller-service-account"},
						},
					},
				},

This PR adds support for arbitrary cluster domains by using the CLUSTER_DOMAIN environment variable.
The environment variable CLUSTER_DOMAIN is optional, so the profile controller uses "cluster.local" as is when not set.

Kindly review this PR.

* Add CLUSTER_DOMAIN environment variable to support arbitrary
  cluster domains other than cluster.local
@kimwnasptd
Copy link
Member

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f40fa35 into kubeflow:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants