jwa(front): Fix the workspace volume form's inputs #7029
Conversation
elenzio9
changed the title
elenzio9
force-pushed
the
feature-elena-jwa-workspace-volume-form-bug
branch
from
7885f7f
to
102c216
Compare
elenzio9
changed the title
elenzio9
force-pushed
the
feature-elena-jwa-workspace-volume-form-bug
branch
from
102c216
to
62fafa8
Compare
| // | ||
| expect(nameValue).equal('-workspace'); // '{notebook-name}-workspace' is the name value of the config fixture |
There was a problem hiding this comment.
The intention here was probably to move the comment from line 87 to where the // are now? Nit but I think it 'd be better this way in order to avoid having a really long line.
| cy.get('[data-cy="workspace volume"]') | ||
| .find('[data-cy="volume name input"]') |
There was a problem hiding this comment.
I think that the cy.get().find() chain is redundant here and you could convert this to cy.get('[data-cy="volume name input"]').
The same goes for all cy.get().find() in the tests introduced. There are cases where we might need to chain cy.get() with .find() but as far as I 'm concerned, this is not the case here. WDYT @elenzio9 ?
There was a problem hiding this comment.
@orfeas-k Thanks for the comments! Just pushed a fixup commit. Please take a look!
The size form input was not showing the correct value, once the frontend got the ConfigMap defaults. We should be updating the intermediate FormControl when the data from the ConfigMap arrives at the frontend. Signed-off-by: Elena Zioga <elena@arrikto.com>
The access mode form input was not showing the correct value, once the frontend got the ConfigMap defaults. We should be updating the intermediate FormControl when the data from the ConfigMap arrives at the frontend. Signed-off-by: Elena Zioga <elena@arrikto.com>
The name form input was not showing the correct value, once the frontend got the ConfigMap defaults. We should be updating the intermediate FormControl when the data from the ConfigMap arrives at the frontend. Signed-off-by: Elena Zioga <elena@arrikto.com>
All new volumes will have a default value of 5Gi. This includes the 'Add new volume' button for both the workspace and data volumes. Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9
force-pushed
the
feature-elena-jwa-workspace-volume-form-bug
branch
from
62fafa8
to
ea6e7d0
Compare
Add integration tests with Cypress to ensure that the form will have the correct values once it gets the ConfigMap. Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9
force-pushed
the
feature-elena-jwa-workspace-volume-form-bug
branch
from
ea6e7d0
to
dc04644
Compare
|
It looks good, I 'll go ahead and merge! @elenzio9 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: orfeas-k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The PR ensures that the intermediate FormControls for the name, size and access modes will be getting updated correctly when the frontend gets the ConfigMap data. It also adds some integration tests for each field to ensure that the form will have the correct values once it gets the ConfigMap.
Related issue: #6741