Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-actions(cdb): Fix Build and Publish action #7031

Merged

Conversation

orfeas-k
Copy link
Contributor

@orfeas-k orfeas-k commented Mar 6, 2023

It looks like after when the PR of mine Show KF Version was merged, the Build & Publish CentralDashboard-Angular Docker image GH action started failing.

This PR fixes the issue which was caused due to shallow clone of the repo. This means that during the clone, git skips cloning the whole history and thus the following docker build command results with an empty kubeflowversion which is defined by this command kubeflowversion=$(shell git describe --abbrev=0 --tags)

docker build  -t centraldashboard-angular:intergration-test -f Dockerfile .. \
	--build-arg kubeflowversion= \
	--build-arg commit=dd3b7e3992d9e5afa6ceaa609e5ea19e904f5665 \
	--label=git-verions=intergration-test

This in return, caused the $BUILD_VERSION to be undefined inside the Dockerfile and thus it failed with the following error

 Step 21/34 : RUN node scripts/replace-string-in-file.js src/environments/environment.prod.ts 'BUILD_VERSION' $BUILD_VERSION
 ---> Running in 39acf1b67aaa
Error, not enough arguments given! This script expects 3 arguments in the following order: File name, String between ${ } that should be replaced, New string

Fix GH action Build & Publish CentralDashboard-Angular Docker image that
failed due to shallow clone of the repo.

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
@kimwnasptd
Copy link
Member

/approve

@kimwnasptd
Copy link
Member

/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit e9d957d into kubeflow:master Mar 14, 2023
@kimwnasptd kimwnasptd deleted the feature-orfeas-fix-gh-actions branch March 14, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants