Training operator conformance test driver #7056
Conversation
|
/cc @johnugeorge |
|
/cc @james-jwu Related: kubeflow/training-operator#1695 Can you review it? |
|
Can you merge everything except training-operator-conformance.yaml into the existing files? Basically you just need to add a command into the existing MAKEFILE for training operator, and hook that into the existing flow. You probably don't need a new directory either. |
nagar-ajay
force-pushed
the
training-operator-conformance
branch
from
48c1921
to
aea4593
Compare
Done |
|
/lgtm @johnugeorge I'll approve after you lgtm this PR. |
| serviceAccountName: kf-conformance | ||
| containers: | ||
| - name: training-conformance-container | ||
| image: kubeflow/training-operator-conformance |
There was a problem hiding this comment.
Can you add tag to the image?
There was a problem hiding this comment.
Updated image tag that has new changes kubeflow/training-operator#1787
nagar-ajay
force-pushed
the
training-operator-conformance
branch
from
ca0a54b
to
9f31044
Compare
|
Thanks @nagar-ajay /cc @james-jwu |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: james-jwu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
README.mdfile contains the instructions to run conformance tests.