Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python linting #7060

Merged

Conversation

kimwnasptd
Copy link
Member

Right now we have a lot of python files but do not do any linting checks on any PRs. As a result running flake8 on the repo produces more than 250 different warnings.

In this PR I've:

  1. Introduced a GH Action that runs whenever a .py file is changed
  2. Runs flake8 to ensure the code is properly formatted
  3. Fixed all the current format warnings

In order to fix most of the errors I used autopep8, which got the errors down to 90. Then some minor edits were done for the rest of the files.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
@elikatsis
Copy link
Member

Thanks for the effort!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elikatsis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 0c0c763 into kubeflow:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants