Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update models.svg #7113

Merged
merged 1 commit into from May 1, 2023
Merged

Conversation

juliusvonkohout
Copy link
Member

flatten paths
@ianonavy
Copy link

ianonavy commented May 1, 2023

LGTM! I didn't do a full end-to-end test with a custom container image off this branch, but copying the file from this revision directly into the DOM appears to work. Since it's just a static file, I don't see why this change wouldn't work.

@kimwnasptd
Copy link
Member

Thanks for this @juliusvonkohout!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 88ac76f into kubeflow:master May 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

models icon (kserve) not inheriting iron icon colors
3 participants