Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GH action integration testing pvcviewer controller #7175

Conversation

TobiasGoerke
Copy link
Contributor

As discussed in #6876, we're adding a GH action that integration tests the pvcviewer controller / its manifests.

The Action is untested and was copied off the notebook controller which works the same way.

This PR is part of three pvcviewer controller workflows. The others are:

@TobiasGoerke
Copy link
Contributor Author

/assign kimwnasptd

@kimwnasptd
Copy link
Member

Awesome!

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jul 20, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit e5b3b9e into kubeflow:master Jul 20, 2023
2 checks passed
@TobiasGoerke TobiasGoerke deleted the feature/volumes-viewer-integration-tests-workflow branch July 22, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants