Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling multi-arch builds for PRs and enable them on Merge for Profile Controller, Profile+KFAM, VWA &TWA #7183

Merged
merged 9 commits into from
Jul 24, 2023

Conversation

pranavpandit1
Copy link
Contributor

this PR ensures that PRs will only trigger an AMD64 build. The multiarc build will only occur when a PR is merged into the main or when a new tag is created.

There is unfortunately, no way to fully test this without merging this PR.

@pranavpandit1 pranavpandit1 changed the title Disabling multi-arch builds for PRs and enable them on Merge for TWA, Profile, VWA &TWA Disabling multi-arch builds for PRs and enable them on Merge for Profile Controller, Profile+KFAM, VWA &TWA Jun 28, 2023
@pranavpandit1
Copy link
Contributor Author

pranavpandit1 commented Jun 29, 2023

@kimwnasptd: This is the second set of https://github.com/kubeflow/kubeflow/pull/7171 . Kindly check
Thanks

@kimwnasptd
Copy link
Member

Thanks @pranavpandit1!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 5cfa81a into kubeflow:master Jul 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants