Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Allow bootstrapper to use disk-based registry #720

Closed
wants to merge 1 commit into from

Conversation

inc0
Copy link

@inc0 inc0 commented Apr 25, 2018

This approach will allow to skip whole GITHUB_TOKEN issue, but is
blocked on this ksonnet/ksonnet#480


This change is Reviewable

This approach will allow to skip whole GITHUB_TOKEN issue, but is
blocked on this ksonnet/ksonnet#480
@pdmack
Copy link
Member

pdmack commented Apr 25, 2018

Could we please change references of "bootstraper" to "bootstrapper"?
/cc @jlewi

@k8s-ci-robot k8s-ci-robot requested a review from jlewi April 25, 2018 13:41
@jlewi
Copy link
Contributor

jlewi commented Apr 25, 2018

@pdmack SGTM.
/assign @kunmingg

@inc0 inc0 changed the title [WIP] Allow bootstraper to use disk-based registry [WIP] Allow bootstrapper to use disk-based registry Apr 25, 2018
@kunmingg
Copy link
Contributor

@inc0 created a PR to enable ks disk-based registry in docker:
#725

@kunmingg
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kunmingg
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: djangopeng

Assign the PR to them by writing /assign @djangopeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@inc0
Copy link
Author

inc0 commented Apr 26, 2018

After your update ks works, but bootstrapper still fails with same issue.

root@74e18df52e17:/# /opt/kubeflow/bootstrapper --registry-dir /opt/kubeflow/kubeflow/ --app-dir=/kubeflow
{"filename":"app/server.go:109","level":"info","msg":"Reading config from file: /root/.kube/config","time":"2018-04-26T10:02:47Z"}
{"filename":"app/server.go:186","level":"info","msg":"Using existing namespace: kubeflow","time":"2018-04-26T10:02:49Z"}
{"filename":"app/server.go:153","level":"info","msg":"Cluster platform: linux/amd64","time":"2018-04-26T10:02:49Z"}
{"filename":"app/server.go:253","level":"info","msg":"Cluster version: v1.9.5","time":"2018-04-26T10:02:49Z"}
{"filename":"app/server.go:160","level":"info","msg":"Storage class: rook-block","time":"2018-04-26T10:02:49Z"}
{"filename":"app/server.go:162","level":"info","msg":"Storage class rook-block doesn't have annotation storageclass.beta.kubernetes.io/is-default-class","time":"2018-04-26T10:02:49Z"}
{"filename":"app/server.go:268","level":"info","msg":"Using K8s host https://8.44.40.57:35000","time":"2018-04-26T10:02:49Z"}
{"filename":"env/create.go:78","level":"info","msg":"Creating environment \"default\" with namespace \"kubeflow\", pointing to cluster at address \"https://8.44.40.57:35000\"","time":"2018-04-26T10:02:49Z"}
{"filename":"lib/lib.go:129","level":"info","msg":"Generating ksonnet-lib data at path '/kubeflow/lib/v1.7.0'","time":"2018-04-26T10:02:50Z"}
{"filename":"app/server.go:292","level":"info","msg":"Successfully initialized the app /kubeflow.","time":"2018-04-26T10:02:50Z"}
{"filename":"app/server.go:350","level":"info","msg":"Installing package kubeflow/core","time":"2018-04-26T10:02:50Z"}
{"filename":"registry/cache.go:83","level":"info","msg":"Retrieved 29 files","time":"2018-04-26T10:02:50Z"}
{"filename":"app/server.go:350","level":"info","msg":"Installing package kubeflow/tf-serving","time":"2018-04-26T10:02:50Z"}
{"filename":"registry/cache.go:83","level":"info","msg":"Retrieved 5 files","time":"2018-04-26T10:02:50Z"}
{"filename":"app/server.go:350","level":"info","msg":"Installing package kubeflow/tf-job","time":"2018-04-26T10:02:50Z"}
{"filename":"registry/cache.go:83","level":"info","msg":"Retrieved 5 files","time":"2018-04-26T10:02:50Z"}
{"filename":"app/server.go:388","level":"fatal","msg":"There was a problem creating protoype package kubeflow-core; error no prototype names matched 'kubeflow-core'","time":"2018-04-26T10:02:50Z"}

@kunmingg
Copy link
Contributor

@inc0 I think we need to update ks version inside vendor as well.
Created issue for it: #727.
Will update it soon.

@jlewi
Copy link
Contributor

jlewi commented May 9, 2018

@inc0 @kunmingg Can we close this issue because @kunmingg created #766?

@inc0 inc0 closed this May 9, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants