fix: viewer-spec.yaml and trigger build #7230
Conversation
|
/assign kimwnasptd |
Two fields are either not correctly indented or named incorrectly
TobiasGoerke
changed the title
TobiasGoerke
changed the title
|
@kimwnasptd my filebrowser PR got finally merged. All uploads are now chunked using the tus protocol and the "old" upload mechanism has been removed entirely in favor of tus. I've now fixed the new filebrowser version in the manifests. This PR should be the last part of the pvcviewer - all local tests and the pvcviewer work great for me. We'll just need a public image. I'll be available over Kubeflow's Slack if you'd like to synchronize during the release phase. |
|
@TobiasGoerke you are on 🔥, awesome work! /lgtm |
|
Can you also send a follow-up PR to cherry-pick this commit to the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks! Looking forward to using this once released! |
* build: minor doc improvement triggering build pipe * fix: viewer-spec.yaml Two fields are either not correctly indented or named incorrectly * fix: add volumes definition required by controller * feat: use filebrowser:v2.24.2 enabling tus uploads (cherry picked from commit 18d175f)
* build: minor doc improvement triggering build pipe (cherry picked from commit 059601e) * fix: viewer-spec.yaml Two fields are either not correctly indented or named incorrectly (cherry picked from commit 27bee23) * fix: add volumes definition required by controller (cherry picked from commit 7de5a99) * feat: use filebrowser:v2.24.2 enabling tus uploads (cherry picked from commit c86e0a6) * fix: downgrade filebrowser this fixes upload issues for cloudflare users we are waiting for a patch version v2.24.3 (cherry picked from commit 91c71ad)
The pvcviewer pipeline has not yet run successfully.
Thus, there is no public image that could be used to test the manifests.
As far as I can tell, this should be the last effort to get the volumes viewer working.
Also, I snuck in another commit, fixing two fields of the viewer-spec.yaml