New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Argo Ksonnet package - Add Docker image Tag #728
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
Review status: 0 of 2 files reviewed at latest revision, all discussions resolved. kubeflow/argo/argo.libsonnet, line 171 at r1 (raw file):
Why are we not tagging the UI image? Comments from Reviewable |
Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion. kubeflow/argo/argo.libsonnet, line 171 at r1 (raw file): Previously, kunmingg wrote…
Forgot to push one commit Comments from Reviewable |
/lgtm |
/ok-to-test |
/assign @willb |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pdmack The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks, @pdmack! |
* Adding imageTag params * updating the ui docker tag
This will allow to use a specific docker image tag for the
exec
andcontroller
image.For example, I hit an issue trying: https://github.com/kubeflow/examples/tree/master/mnist I fixed it using the
v2.1.0-beta2
tag.This change is