Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argo Ksonnet package - Add Docker image Tag #728

Merged
merged 2 commits into from May 2, 2018

Conversation

julienstroheker
Copy link
Contributor

@julienstroheker julienstroheker commented Apr 26, 2018

This will allow to use a specific docker image tag for the exec and controller image.

For example, I hit an issue trying: https://github.com/kubeflow/examples/tree/master/mnist I fixed it using the v2.1.0-beta2 tag.


This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@julienstroheker
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@kunmingg
Copy link
Contributor

Review status: 0 of 2 files reviewed at latest revision, all discussions resolved.


kubeflow/argo/argo.libsonnet, line 171 at r1 (raw file):

                  },
                ],
                image: "argoproj/argoui:v2.0.0-beta1",

Why are we not tagging the UI image?


Comments from Reviewable

@julienstroheker
Copy link
Contributor Author

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.


kubeflow/argo/argo.libsonnet, line 171 at r1 (raw file):

Previously, kunmingg wrote…

Why are we not tagging the UI image?

Forgot to push one commit


Comments from Reviewable

@kunmingg
Copy link
Contributor

/lgtm

@pdmack
Copy link
Member

pdmack commented Apr 27, 2018

/ok-to-test

@julienstroheker
Copy link
Contributor Author

/assign @willb

@pdmack
Copy link
Member

pdmack commented May 2, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pdmack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@willb
Copy link
Contributor

willb commented May 2, 2018

Thanks, @pdmack!

@k8s-ci-robot k8s-ci-robot merged commit 437287c into kubeflow:master May 2, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* Adding imageTag params

* updating the ui docker tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants