Release v1.8.0-rc.1 #7286

DnPlas · 2023-09-19T18:12:07Z

Bump release version v1.8.0-rc.0 -> v1.8.0-rc.1

kimwnasptd · 2023-09-19T18:47:59Z

It looks like we still have a race where our tests will directly kubectl wait pod but the Deployment object might not yet have created the Pods. To resolve this I suggest that we wait for the Deployment instead of the Pod.

@DnPlas we could copy-paste the logic for this from my original PR in #7252 (the part that we wait for the deployment, not the one that we patch it)

Could you send a PR for this? Asking you since we are burning with the release and I can help merge this fast

also cc @thesuperzapper since this is related to our discussion on the CI

Signed-off-by: Daniela Plascencia <daniela.plascencia@canonical.com>

kimwnasptd · 2023-09-19T21:16:54Z

@TobiasGoerke could you help us debug the failing unit tests for the PVCViewer Controller?

I see the following relevant logs, that come from the following line in the code
https://github.com/kubeflow/kubeflow/blob/08eaaba1095455b3b44485e697bae8324ad8eaf8/components/pvcviewer-controller/controllers/pvcviewer_controller_test.go#L387C1-L387C7

• [FAILED] [0.027 seconds]
PVCViewer controller
/home/runner/work/kubeflow/kubeflow/components/pvcviewer-controller/controllers/pvcviewer_controller_test.go:30
  When RWO Scheduling is used
  /home/runner/work/kubeflow/kubeflow/components/pvcviewer-controller/controllers/pvcviewer_controller_test.go:370
    [It] Does not generate affinities for RWX PVCs
    /home/runner/work/kubeflow/kubeflow/components/pvcviewer-controller/controllers/pvcviewer_controller_test.go:371

Begin Captured GinkgoWriter Output >>
    STEP: Creating a RWX PVC and mounting Pod 09/19/23 19:33:32.07
    STEP: Creating a PVCViewer for the RWX PVC 09/19/23 19:33:32.074
    1.6951520120758505e+09	DEBUG	controller-runtime.webhook.webhooks	received request	{"webhook": "/mutate-kubeflow-org-v1alpha1-pvcviewer", "UID": "3936385e-5bda-4b4a-9a48-17d3bee931af", "kind": "kubeflow.org/v1alpha1, Kind=PVCViewer", "resource": {"group":"kubeflow.org","version":"v1alpha1","resource":"pvcviewers"}}
    1.6951520120759068e+09	INFO	pvcviewer-resource	default	{"name": "test-pvcviewer"}
    1.6951520120759153e+09	INFO	pvcviewer-resource	Inferring default podSpec	{"name": "test-pvcviewer"}
    1.6951520120760825e+09	DEBUG	controller-runtime.webhook.webhooks	wrote response	{"webhook": "/mutate-kubeflow-org-v1alpha1-pvcviewer", "code": 200, "reason": "", "UID": "3936385e-5bda-4b4a-9a48-17d3bee931af", "allowed": true}
    1.6951520120772035e+09	DEBUG	controller-runtime.webhook.webhooks	received request	{"webhook": "/validate-kubeflow-org-v1alpha1-pvcviewer", "UID": "32162513-9212-4426-a50f-964ace887c19", "kind": "kubeflow.org/v1alpha1, Kind=PVCViewer", "resource": {"group":"kubeflow.org","version":"v1alpha1","resource":"pvcviewers"}}
    1.6951520120772767e+09	INFO	pvcviewer-resource	validate create	{"name": "test-pvcviewer"}
    1.6951520120772908e+09	DEBUG	controller-runtime.webhook.webhooks	wrote response	{"webhook": "/validate-kubeflow-org-v1alpha1-pvcviewer", "code": 200, "reason": "", "UID": "32162513-9212-4426-a50f-964ace887c19", "allowed": true}
    1.6951520120787518e+09	INFO	Creating Deployment	{"controller": "pvcviewer", "controllerGroup": "kubeflow.org", "controllerKind": "PVCViewer", "PVCViewer": {"name":"test-pvcviewer","namespace":"test-9"}, "namespace": "test-9", "name": "test-pvcviewer", "reconcileID": "0d3ed72e-7f25-4e6d-b47e-ad6be1c725e7"}
    1.6951520120819845e+09	INFO	Updating status	{"controller": "pvcviewer", "controllerGroup": "kubeflow.org", "controllerKind": "PVCViewer", "PVCViewer": {"name":"test-pvcviewer","namespace":"test-9"}, "namespace": "test-9", "name": "test-pvcviewer", "reconcileID": "0d3ed72e-7f25-4e6d-b47e-ad6be1c725e7"}
...
    1.695152012089806e+09	ERROR	Reconciler error	{"controller": "pvcviewer", "controllerGroup": "kubeflow.org", "controllerKind": "PVCViewer", "PVCViewer": {"name":"test-pvcviewer","namespace":"test-9"}, "namespace": "test-9", "name": "test-pvcviewer", "reconcileID": "e0663be8-fa85-45ae-84e6-a552e2d3c4b5", "error": "PVCViewer.kubeflow.org \"test-pvcviewer\" not found"}
    sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
    	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:326
    sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
    	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:273
    sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
    	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:234
  << End Captured GinkgoWriter Output

TobiasGoerke · 2023-09-20T10:15:42Z

@TobiasGoerke could you help us debug the failing unit tests for the PVCViewer Controller?

I see the following relevant logs, that come from the following line in the code https://github.com/kubeflow/kubeflow/blob/08eaaba1095455b3b44485e697bae8324ad8eaf8/components/pvcviewer-controller/controllers/pvcviewer_controller_test.go#L387C1-L387C7

• [FAILED] [0.027 seconds]
PVCViewer controller
/home/runner/work/kubeflow/kubeflow/components/pvcviewer-controller/controllers/pvcviewer_controller_test.go:30
  When RWO Scheduling is used
  /home/runner/work/kubeflow/kubeflow/components/pvcviewer-controller/controllers/pvcviewer_controller_test.go:370
    [It] Does not generate affinities for RWX PVCs
    /home/runner/work/kubeflow/kubeflow/components/pvcviewer-controller/controllers/pvcviewer_controller_test.go:371

Begin Captured GinkgoWriter Output >>
    STEP: Creating a RWX PVC and mounting Pod 09/19/23 19:33:32.07
    STEP: Creating a PVCViewer for the RWX PVC 09/19/23 19:33:32.074
    1.6951520120758505e+09	DEBUG	controller-runtime.webhook.webhooks	received request	{"webhook": "/mutate-kubeflow-org-v1alpha1-pvcviewer", "UID": "3936385e-5bda-4b4a-9a48-17d3bee931af", "kind": "kubeflow.org/v1alpha1, Kind=PVCViewer", "resource": {"group":"kubeflow.org","version":"v1alpha1","resource":"pvcviewers"}}
    1.6951520120759068e+09	INFO	pvcviewer-resource	default	{"name": "test-pvcviewer"}
    1.6951520120759153e+09	INFO	pvcviewer-resource	Inferring default podSpec	{"name": "test-pvcviewer"}
    1.6951520120760825e+09	DEBUG	controller-runtime.webhook.webhooks	wrote response	{"webhook": "/mutate-kubeflow-org-v1alpha1-pvcviewer", "code": 200, "reason": "", "UID": "3936385e-5bda-4b4a-9a48-17d3bee931af", "allowed": true}
    1.6951520120772035e+09	DEBUG	controller-runtime.webhook.webhooks	received request	{"webhook": "/validate-kubeflow-org-v1alpha1-pvcviewer", "UID": "32162513-9212-4426-a50f-964ace887c19", "kind": "kubeflow.org/v1alpha1, Kind=PVCViewer", "resource": {"group":"kubeflow.org","version":"v1alpha1","resource":"pvcviewers"}}
    1.6951520120772767e+09	INFO	pvcviewer-resource	validate create	{"name": "test-pvcviewer"}
    1.6951520120772908e+09	DEBUG	controller-runtime.webhook.webhooks	wrote response	{"webhook": "/validate-kubeflow-org-v1alpha1-pvcviewer", "code": 200, "reason": "", "UID": "32162513-9212-4426-a50f-964ace887c19", "allowed": true}
    1.6951520120787518e+09	INFO	Creating Deployment	{"controller": "pvcviewer", "controllerGroup": "kubeflow.org", "controllerKind": "PVCViewer", "PVCViewer": {"name":"test-pvcviewer","namespace":"test-9"}, "namespace": "test-9", "name": "test-pvcviewer", "reconcileID": "0d3ed72e-7f25-4e6d-b47e-ad6be1c725e7"}
    1.6951520120819845e+09	INFO	Updating status	{"controller": "pvcviewer", "controllerGroup": "kubeflow.org", "controllerKind": "PVCViewer", "PVCViewer": {"name":"test-pvcviewer","namespace":"test-9"}, "namespace": "test-9", "name": "test-pvcviewer", "reconcileID": "0d3ed72e-7f25-4e6d-b47e-ad6be1c725e7"}
...
    1.695152012089806e+09	ERROR	Reconciler error	{"controller": "pvcviewer", "controllerGroup": "kubeflow.org", "controllerKind": "PVCViewer", "PVCViewer": {"name":"test-pvcviewer","namespace":"test-9"}, "namespace": "test-9", "name": "test-pvcviewer", "reconcileID": "e0663be8-fa85-45ae-84e6-a552e2d3c4b5", "error": "PVCViewer.kubeflow.org \"test-pvcviewer\" not found"}
    sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
    	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:326
    sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
    	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:273
    sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
    	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:234
  << End Captured GinkgoWriter Output

Not sure why this test starts failing now and without changes. I've only been able to reproduce the error about twice by running a few hundred times and have yet to see it in production. Judging by this issue and this one, we're not alone with this issue and I'd assume its related to a race condition in our testing environment.
Could you please re-trigger the pipeline? If it continues to fail, I'd suggest we ignore this test for now and wait for an upstream fix.

DnPlas · 2023-09-20T14:44:34Z

@TobiasGoerke could you help us debug the failing unit tests for the PVCViewer Controller?
I see the following relevant logs, that come from the following line in the code https://github.com/kubeflow/kubeflow/blob/08eaaba1095455b3b44485e697bae8324ad8eaf8/components/pvcviewer-controller/controllers/pvcviewer_controller_test.go#L387C1-L387C7

• [FAILED] [0.027 seconds]
PVCViewer controller
/home/runner/work/kubeflow/kubeflow/components/pvcviewer-controller/controllers/pvcviewer_controller_test.go:30
  When RWO Scheduling is used
  /home/runner/work/kubeflow/kubeflow/components/pvcviewer-controller/controllers/pvcviewer_controller_test.go:370
    [It] Does not generate affinities for RWX PVCs
    /home/runner/work/kubeflow/kubeflow/components/pvcviewer-controller/controllers/pvcviewer_controller_test.go:371

Begin Captured GinkgoWriter Output >>
    STEP: Creating a RWX PVC and mounting Pod 09/19/23 19:33:32.07
    STEP: Creating a PVCViewer for the RWX PVC 09/19/23 19:33:32.074
    1.6951520120758505e+09	DEBUG	controller-runtime.webhook.webhooks	received request	{"webhook": "/mutate-kubeflow-org-v1alpha1-pvcviewer", "UID": "3936385e-5bda-4b4a-9a48-17d3bee931af", "kind": "kubeflow.org/v1alpha1, Kind=PVCViewer", "resource": {"group":"kubeflow.org","version":"v1alpha1","resource":"pvcviewers"}}
    1.6951520120759068e+09	INFO	pvcviewer-resource	default	{"name": "test-pvcviewer"}
    1.6951520120759153e+09	INFO	pvcviewer-resource	Inferring default podSpec	{"name": "test-pvcviewer"}
    1.6951520120760825e+09	DEBUG	controller-runtime.webhook.webhooks	wrote response	{"webhook": "/mutate-kubeflow-org-v1alpha1-pvcviewer", "code": 200, "reason": "", "UID": "3936385e-5bda-4b4a-9a48-17d3bee931af", "allowed": true}
    1.6951520120772035e+09	DEBUG	controller-runtime.webhook.webhooks	received request	{"webhook": "/validate-kubeflow-org-v1alpha1-pvcviewer", "UID": "32162513-9212-4426-a50f-964ace887c19", "kind": "kubeflow.org/v1alpha1, Kind=PVCViewer", "resource": {"group":"kubeflow.org","version":"v1alpha1","resource":"pvcviewers"}}
    1.6951520120772767e+09	INFO	pvcviewer-resource	validate create	{"name": "test-pvcviewer"}
    1.6951520120772908e+09	DEBUG	controller-runtime.webhook.webhooks	wrote response	{"webhook": "/validate-kubeflow-org-v1alpha1-pvcviewer", "code": 200, "reason": "", "UID": "32162513-9212-4426-a50f-964ace887c19", "allowed": true}
    1.6951520120787518e+09	INFO	Creating Deployment	{"controller": "pvcviewer", "controllerGroup": "kubeflow.org", "controllerKind": "PVCViewer", "PVCViewer": {"name":"test-pvcviewer","namespace":"test-9"}, "namespace": "test-9", "name": "test-pvcviewer", "reconcileID": "0d3ed72e-7f25-4e6d-b47e-ad6be1c725e7"}
    1.6951520120819845e+09	INFO	Updating status	{"controller": "pvcviewer", "controllerGroup": "kubeflow.org", "controllerKind": "PVCViewer", "PVCViewer": {"name":"test-pvcviewer","namespace":"test-9"}, "namespace": "test-9", "name": "test-pvcviewer", "reconcileID": "0d3ed72e-7f25-4e6d-b47e-ad6be1c725e7"}
...
    1.695152012089806e+09	ERROR	Reconciler error	{"controller": "pvcviewer", "controllerGroup": "kubeflow.org", "controllerKind": "PVCViewer", "PVCViewer": {"name":"test-pvcviewer","namespace":"test-9"}, "namespace": "test-9", "name": "test-pvcviewer", "reconcileID": "e0663be8-fa85-45ae-84e6-a552e2d3c4b5", "error": "PVCViewer.kubeflow.org \"test-pvcviewer\" not found"}
    sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
    	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:326
    sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
    	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:273
    sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
    	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:234
  << End Captured GinkgoWriter Output

Not sure why this test starts failing now and without changes. I've only been able to reproduce the error about twice by running a few hundred times and have yet to see it in production. Judging by this issue and this one, we're not alone with this issue and I'd assume its related to a race condition in our testing environment. Could you please re-trigger the pipeline? If it continues to fail, I'd suggest we ignore this test for now and wait for an upstream fix.

Seems like it happened again see latest run. I will let @kimwnasptd consider the next steps.

TobiasGoerke · 2023-09-20T17:24:41Z

@TobiasGoerke could you help us debug the failing unit tests for the PVCViewer Controller?
I see the following relevant logs, that come from the following line in the code https://github.com/kubeflow/kubeflow/blob/08eaaba1095455b3b44485e697bae8324ad8eaf8/components/pvcviewer-controller/controllers/pvcviewer_controller_test.go#L387C1-L387C7

• [FAILED] [0.027 seconds]
PVCViewer controller
/home/runner/work/kubeflow/kubeflow/components/pvcviewer-controller/controllers/pvcviewer_controller_test.go:30
  When RWO Scheduling is used
  /home/runner/work/kubeflow/kubeflow/components/pvcviewer-controller/controllers/pvcviewer_controller_test.go:370
    [It] Does not generate affinities for RWX PVCs
    /home/runner/work/kubeflow/kubeflow/components/pvcviewer-controller/controllers/pvcviewer_controller_test.go:371

Begin Captured GinkgoWriter Output >>
    STEP: Creating a RWX PVC and mounting Pod 09/19/23 19:33:32.07
    STEP: Creating a PVCViewer for the RWX PVC 09/19/23 19:33:32.074
    1.6951520120758505e+09	DEBUG	controller-runtime.webhook.webhooks	received request	{"webhook": "/mutate-kubeflow-org-v1alpha1-pvcviewer", "UID": "3936385e-5bda-4b4a-9a48-17d3bee931af", "kind": "kubeflow.org/v1alpha1, Kind=PVCViewer", "resource": {"group":"kubeflow.org","version":"v1alpha1","resource":"pvcviewers"}}
    1.6951520120759068e+09	INFO	pvcviewer-resource	default	{"name": "test-pvcviewer"}
    1.6951520120759153e+09	INFO	pvcviewer-resource	Inferring default podSpec	{"name": "test-pvcviewer"}
    1.6951520120760825e+09	DEBUG	controller-runtime.webhook.webhooks	wrote response	{"webhook": "/mutate-kubeflow-org-v1alpha1-pvcviewer", "code": 200, "reason": "", "UID": "3936385e-5bda-4b4a-9a48-17d3bee931af", "allowed": true}
    1.6951520120772035e+09	DEBUG	controller-runtime.webhook.webhooks	received request	{"webhook": "/validate-kubeflow-org-v1alpha1-pvcviewer", "UID": "32162513-9212-4426-a50f-964ace887c19", "kind": "kubeflow.org/v1alpha1, Kind=PVCViewer", "resource": {"group":"kubeflow.org","version":"v1alpha1","resource":"pvcviewers"}}
    1.6951520120772767e+09	INFO	pvcviewer-resource	validate create	{"name": "test-pvcviewer"}
    1.6951520120772908e+09	DEBUG	controller-runtime.webhook.webhooks	wrote response	{"webhook": "/validate-kubeflow-org-v1alpha1-pvcviewer", "code": 200, "reason": "", "UID": "32162513-9212-4426-a50f-964ace887c19", "allowed": true}
    1.6951520120787518e+09	INFO	Creating Deployment	{"controller": "pvcviewer", "controllerGroup": "kubeflow.org", "controllerKind": "PVCViewer", "PVCViewer": {"name":"test-pvcviewer","namespace":"test-9"}, "namespace": "test-9", "name": "test-pvcviewer", "reconcileID": "0d3ed72e-7f25-4e6d-b47e-ad6be1c725e7"}
    1.6951520120819845e+09	INFO	Updating status	{"controller": "pvcviewer", "controllerGroup": "kubeflow.org", "controllerKind": "PVCViewer", "PVCViewer": {"name":"test-pvcviewer","namespace":"test-9"}, "namespace": "test-9", "name": "test-pvcviewer", "reconcileID": "0d3ed72e-7f25-4e6d-b47e-ad6be1c725e7"}
...
    1.695152012089806e+09	ERROR	Reconciler error	{"controller": "pvcviewer", "controllerGroup": "kubeflow.org", "controllerKind": "PVCViewer", "PVCViewer": {"name":"test-pvcviewer","namespace":"test-9"}, "namespace": "test-9", "name": "test-pvcviewer", "reconcileID": "e0663be8-fa85-45ae-84e6-a552e2d3c4b5", "error": "PVCViewer.kubeflow.org \"test-pvcviewer\" not found"}
    sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
    	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:326
    sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
    	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:273
    sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
    	/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/internal/controller/controller.go:234
  << End Captured GinkgoWriter Output

Not sure why this test starts failing now and without changes. I've only been able to reproduce the error about twice by running a few hundred times and have yet to see it in production. Judging by this issue and this one, we're not alone with this issue and I'd assume its related to a race condition in our testing environment. Could you please re-trigger the pipeline? If it continues to fail, I'd suggest we ignore this test for now and wait for an upstream fix.

Seems like it happened again see latest run. I will let @kimwnasptd consider the next steps.

Well, now we're running into a new problem. The tests download the latest istio CRD which is required for testing. However, that path just changed to https://raw.githubusercontent.com/kubeflow/manifests/master/common/istio-1-17/istio-crds/base/crd.yaml, which causes an invalid file to be downloaded, failing all tests. This is easy to fix. Also, we might be better off copying that file statically without downloading it manually, as this is bound to happen again.

I'll created PRs against both master and your dnplas-bump-version-1.8.0-rc.1 branch:

fix: pvcviewer tests #7292 (find the tests succeeding)
fix: pvcviewer tests DnPlas/kubeflow#1

Changes filepaths on master caused the download of CRDs to fail. Instead, we now add the CRDs statically, to prevent issues like these. See for more info: kubeflow#7286 (comment)

Changes filepaths on master caused the download of CRDs to fail. Instead, we now add the CRDs statically, to prevent issues like these. See for more info: kubeflow#7286 (comment) (cherry picked from commit 16b3743)

Changes filepaths on master caused the download of CRDs to fail. Instead, we now add the CRDs statically, to prevent issues like these. See for more info: #7286 (comment)

Changes filepaths on master caused the download of CRDs to fail. Instead, we now add the CRDs statically, to prevent issues like these. See for more info: kubeflow#7286 (comment) (cherry picked from commit 16b3743)

DnPlas · 2023-09-21T09:06:08Z

Thanks @TobiasGoerke !

kimwnasptd · 2023-09-21T10:21:33Z

So nice to see everything green! Thank you both @DnPlas @TobiasGoerke!

/lgtm
/approve

google-oss-prow · 2023-09-21T10:21:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~components/admission-webhook/OWNERS~~ [kimwnasptd]
~~components/centraldashboard/OWNERS~~ [kimwnasptd]
~~components/crud-web-apps/OWNERS~~ [kimwnasptd]
~~components/notebook-controller/OWNERS~~ [kimwnasptd]
~~components/profile-controller/OWNERS~~ [kimwnasptd]
~~components/pvcviewer-controller/OWNERS~~ [kimwnasptd]
~~components/tensorboard-controller/OWNERS~~ [kimwnasptd]
~~releasing/OWNERS~~ [kimwnasptd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

TobiasGoerke · 2023-09-21T10:41:23Z

Nice! Great to be part of this release. Thanks for the support @DnPlas @kimwnasptd

google-oss-prow bot added the size/M label Sep 19, 2023

google-oss-prow bot requested review from MartinForReal and SachinVarghese September 19, 2023 18:13

Release v1.8.0-rc.1

2ee2fef

Signed-off-by: Daniela Plascencia <daniela.plascencia@canonical.com>

DnPlas force-pushed the dnplas-bump-version-1.8.0-rc.1 branch from 543dfe2 to 2ee2fef Compare September 19, 2023 19:30

TobiasGoerke mentioned this pull request Sep 20, 2023

fix: pvcviewer tests #7292

Merged

google-oss-prow bot pushed a commit that referenced this pull request Sep 21, 2023

fix: pvcviewer tests (#7292)

0a2ecef

Changes filepaths on master caused the download of CRDs to fail. Instead, we now add the CRDs statically, to prevent issues like these. See for more info: #7286 (comment)

fix: pvcviewer crd downloading

a5f1f4d

Changes filepaths on master caused the download of CRDs to fail. Instead, we now add the CRDs statically, to prevent issues like these. See for more info: kubeflow#7286 (comment) (cherry picked from commit 16b3743)

google-oss-prow bot added size/XXL and removed size/M labels Sep 21, 2023

google-oss-prow bot assigned kimwnasptd Sep 21, 2023

google-oss-prow bot added the lgtm label Sep 21, 2023

google-oss-prow bot added the approved label Sep 21, 2023

google-oss-prow bot merged commit 31a0675 into kubeflow:v1.8-branch Sep 21, 2023
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v1.8.0-rc.1 #7286

Release v1.8.0-rc.1 #7286

DnPlas commented Sep 19, 2023 •

edited

kimwnasptd commented Sep 19, 2023

kimwnasptd commented Sep 19, 2023

TobiasGoerke commented Sep 20, 2023

DnPlas commented Sep 20, 2023

TobiasGoerke commented Sep 20, 2023 •

edited

DnPlas commented Sep 21, 2023

kimwnasptd commented Sep 21, 2023

google-oss-prow bot commented Sep 21, 2023

TobiasGoerke commented Sep 21, 2023

Release v1.8.0-rc.1 #7286

Release v1.8.0-rc.1 #7286

Conversation

DnPlas commented Sep 19, 2023 • edited

kimwnasptd commented Sep 19, 2023

kimwnasptd commented Sep 19, 2023

TobiasGoerke commented Sep 20, 2023

DnPlas commented Sep 20, 2023

TobiasGoerke commented Sep 20, 2023 • edited

DnPlas commented Sep 21, 2023

kimwnasptd commented Sep 21, 2023

google-oss-prow bot commented Sep 21, 2023

TobiasGoerke commented Sep 21, 2023

DnPlas commented Sep 19, 2023 •

edited

TobiasGoerke commented Sep 20, 2023 •

edited