Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wa(front): Make the background white of all webapps #7341

Conversation

kimwnasptd
Copy link
Member

Right now the web-apps all become grey, because of a transparency change introduced by d4b6dff
image

/assign @thesuperzapper

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kimwnasptd for the fix, approved!

@orfeas-k
Copy link
Contributor

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orfeas-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 5302ed1 into kubeflow:master Oct 13, 2023
10 checks passed
@kimwnasptd kimwnasptd deleted the feature-kimwnasptd-wa-white-background branch October 13, 2023 12:28
kimwnasptd added a commit to kimwnasptd/kubeflow that referenced this pull request Oct 15, 2023
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
google-oss-prow bot pushed a commit that referenced this pull request Oct 16, 2023
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
…w#7341)

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
…w#7341)

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
…w#7341)

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 23, 2024
…w#7341)

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 23, 2024
…w#7341)

Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants