-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Push the multi-arch image for specific tag #7345
ci: Push the multi-arch image for specific tag #7345
Conversation
The latest changes made the CI to only build the images for different archs, but not push for the tag value of the commit. While next steps, for pushing the latest tag or a release version tag will work we still want to ensure we push an image with a tag. Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
/lgtm |
642f39b
to
b95a5e7
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The latest changes made the CI to only build the images for different archs, but not push for the tag value of the commit. While next steps, for pushing the latest tag or a release version tag will work we still want to ensure we push an image with a tag. Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
* ci: Build ARM images for core components (#7220) * ci: Build ARM images for core components Extend the GH Actions to also build the images on ARM architectures. Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * crud-web-apps: Update python and gevent versions In order to successfully build on linux/arm64/v8 we'll need to: * Update to Python 3.10 * Bump the gevent version gevent/gevent#1721 (comment) * Update the workflows for JWA Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * Update workflows for centraldb Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * Update workflows for kfam Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * Update workflows for notebook-controller Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * Update workflows for PodDefaults Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * Update workflows for Profile Controller Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * Update workflows for pvcviewer controller Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * Update workflows for TensorBoard Controller Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * Update workflows for TWA Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * Update workflows for VWA Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * Update releasing script to include PVCViewers Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> --------- Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * Run build steps for multi-arch sequentially (#7333) * Run build steps for multi-arch sequentially We saw that if we try to build using an ENV var containing all the architectures then docker buildx will run 3 parallel jobs. This made the GH runners crash in some cases because they were over-utilizing the resources. To mitigate this we'll sequentially build each image for each arch. Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * review: Build first for amd64 Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> --------- Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * ci: Ensure we publish for all architectures (#7343) Previously we omitted the ARCH env var, which resulted in the last step to not push for all architectures, but only for amd64. This commit will set a default ENV var with all architectures, which will be picked up by the build-push make rule we have. Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * ci: Push the multi-arch image for specific tag (#7345) The latest changes made the CI to only build the images for different archs, but not push for the tag value of the commit. While next steps, for pushing the latest tag or a release version tag will work we still want to ensure we push an image with a tag. Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> --------- Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
#7333 made the CI to only build the images for different archs, but not push for the tag value of the commit.
This is because the code replaced
# make docker-build-push-multi-arch ARCH=amd64 make docker-build-multi-arch
While pushing the
latest
tag or a release version tag will work we still want to ensure we push an image with a tag.You can find a docker image built with the above action , and the workflow that produced it in
https://github.com/kimwnasptd/kubeflow/actions/runs/6526089745/job/17719463473