Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: point to ~kubeflow/styles/fonts.scss #7352

Merged

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Oct 16, 2023

It seems like the path to this file recently changed by #7062, which is now preventing the centraldashboard Docker image to build wich fails with a SassError when trying to import fonts.scss. This commit points to the right path.

Error log for reference:

 #27 90.64 ./src/styles/styles.scss - Error: Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
#27 90.64 ModuleBuildError: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
#27 90.64 SassError: Can't find stylesheet to import.
#27 90.64    ╷
#27 90.64 11 │ @import '~kubeflow/lib/fonts.scss';
#27 90.64    │         ^^^^^^^^^^^^^^^^^^^^^^^^^^
#27 90.64    ╵
#27 90.64   src/styles/styles.scss 11:9  root stylesheet

See this build for more information.

It seems like the path to this file recently changed by kubeflow#7062,
which is now preventing the centraldashboard Docker image to
build wich fails with a SassError when trying to import fonts.scss.
This commit points to the right path.
@orfeas-k
Copy link
Contributor

Thank you @DnPlas for the fixes. These actually make sense after #7062.
/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orfeas-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 3c958b5 into kubeflow:v1.8-branch Oct 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants