ci: fix version tagging of notebook server images #7386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to quickly merge this and cut a new RC for 1.8, as right now, the notebook server image tags for /assign @kimwnasptd @DnPlas |
This was referenced Oct 25, 2023
DnPlas
approved these changes
Oct 25, 2023
|
/lgtm |
|
Self-approving, because we need to get this cut ASAP, and is a minor fix. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DnPlas, thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
DnPlas
pushed a commit
to DnPlas/kubeflow
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a small bug in the CI from #7357, which cause the release version tags to not be created (when the
releasing/version/VERSIONfile is updated).It was simply doing the
cdtoo early, so the relative path was not correct.We will probably need to quickly do a
1.8.0-rc.5after cherry-picking this pr into thev1.8-branch.