ci: prevent triggering release builds accidentally #7401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @DnPlas |
|
Once we merge this, we need to cherry-pick it into the |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
DnPlas
pushed a commit
to DnPlas/kubeflow
that referenced
this pull request
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a serious bug in the CI which may result in image tags being re-pushed post-release.
The issue is that our current system to detect when the
releasing/version/VERSIONfile has changed (and thus a new "release" image tag needs to be created) will trigger 100% of the time.This is because, by default, the
dorny/paths-filter@v2will compare againstmaster, even if the push was to thev1.8-branch, and there will always be a different on thereleasing/version/VERSIONbetween master and release branches.This PR simply uses
${{ github.ref }}as the base of comparison, as suggested by the author ofdorny/paths-filterfor long-lived branches.