Make TFJob operator a standalone prototype #743
Conversation
pdmack
force-pushed
the
669-tfjob-prototype
branch
from
edb16ff
to
503bcfc
Compare
ks init my-tf-job
cd my-tf-job/
ks registry add kubeflow github.com/pdmack/kubeflow/tree/669-tfjob-prototype/kubeflow
ks pkg install kubeflow/tf-job@669-tfjob-prototype
ks generate tf-job-operator tf-job-operator
ks apply default -c tf-job-operator |
pdmack
changed the title
pdmack
force-pushed
the
669-tfjob-prototype
branch
from
503bcfc
to
a8b25d1
Compare
kubeflow/core/all.libsonnet
Outdated
| local spartakus = import "kubeflow/core/spartakus.libsonnet", | ||
| local centraldashboard = import "kubeflow/core/centraldashboard.libsonnet", | ||
| local version = import "kubeflow/core/version.libsonnet", | ||
|
|
||
| all:: jupyterhub.all(params) | ||
| + tfjob.all(params) | ||
| + ambassador.all(params) |
There was a problem hiding this comment.
I think the all prototype should continue to install the TFJob operator. This way folks who want all the components can install them with a single package. But we can also have a prototype for just TFJob.
| @@ -0,0 +1,26 @@ | |||
| // @apiVersion 0.1 | |||
There was a problem hiding this comment.
Do you think moving TFJob operator into the TFJob package makes sense? I'm uncertain what the proper organization of packages should be (see #106).
Its convenient for users not to install additional packages. Also, I think we'd like the all prototype to still install the TFJob operator. ksonnet doesn't handle dependencies between packages very well.
I'm not sure it makes sense to have a package just for TFJob. It might make sense to have a package for TensorFlow and put all the components for TensorFlow into that package.
What do you think?
There was a problem hiding this comment.
Ah, I see. Seems I was a little overzealous in breaking out the TFJob operator. ;-)
I do still think it's important to distinguish it from the "user" TFJob prototype.
So, I would prefer to name it one of:
- tf-job-operator
- tf-job-admin
- tf-job-service
- etc.
There was a problem hiding this comment.
tf-job-operator seems like a good name to me for the prototype.
pdmack
changed the title
pdmack
changed the title
|
How's this coming? |
|
@jlewi next up after |
pdmack
force-pushed
the
669-tfjob-prototype
branch
2 times, most recently
from
e42ffc2
to
32e0a4e
Compare
pdmack
force-pushed
the
669-tfjob-prototype
branch
from
32e0a4e
to
3ac6132
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
pdmack
changed the title
|
Thanks! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* feat: Fix the API Signed-off-by: Ce Gao <gaoce@caicloud.io> * fix: Code generate Signed-off-by: Ce Gao <gaoce@caicloud.io> * fix: Remove the implementation Signed-off-by: Ce Gao <gaoce@caicloud.io> * fix: Fix CI Signed-off-by: Ce Gao <gaoce@caicloud.io> * fix: Fix import Signed-off-by: Ce Gao <gaoce@caicloud.io> * fix: Fix test case Signed-off-by: Ce Gao <gaoce@caicloud.io> * fix: Fix test Signed-off-by: Ce Gao <gaoce@caicloud.io> * fix: Remove manager test Signed-off-by: Ce Gao <gaoce@caicloud.io>
* Rename katib-manager to katib-db-manager * update tags * add files * change mysql * add missing files * fix component name * fix component name * rename component name
Closes #669
PTAL
/cc @jlewi
/cc @DjangoPeng
Wasn't quite sure what to do with
testing/workflowsso left that more or less intact for now.This change is