support IAP setup for bootstrap on GKE #744
Conversation
|
/assign @ankushagarwal |
|
Can you add a reference to the issue in the PR description |
bootstrap/README.md
Outdated
| # (Optional) enable usage reporting | ||
| **Inside container, choose one way to generate kubeflow apps**: | ||
| 1. On GKE, with Google Sign-in enabled for kubeflow (share access with your team easily): | ||
| [Finish Preliminaries](https://github.com/kubeflow/kubeflow/tree/master/bootstrap#iap-preliminaries) |
There was a problem hiding this comment.
Can you make link relative instead of absolute?
bootstrap/README.md
Outdated
| @@ -21,47 +21,57 @@ and based on the results chooses good values for various Kubeflow parameters. | |||
|
|
|||
| **Alpha stage(as of today) Requires** run ```make build``` to build docker image locally since there's no public release yet. | |||
|
|
|||
| Interactive use | |||
| **Enter interactive-use container**: | |||
|
|
|||
| ``` | |||
| TAG=latest | |||
| APP_DIR_HOST=<Directory on host machine for the ksonnet apps> | |||
There was a problem hiding this comment.
APP_DIR_HOST=$HOME/ksonnetApps # Directory on host machine for the ksonnet apps
It will be good to provide a default location so that user can just copy-paste
| @@ -157,6 +167,26 @@ Potential solutions | |||
| - e.g. if a pod depends on a volume or ConfigMap that pod won't be scheduled | |||
| until the config map exists | |||
|
|
|||
| ## IAP Preliminaries: | |||
| 1. [Create external static IP address named kubeflow](https://github.com/kubeflow/kubeflow/blob/master/docs/gke/iap.md#create-an-external-static-ip-address) | |||
There was a problem hiding this comment.
Can this be created automatically by the bootstrapper?
There was a problem hiding this comment.
Deployment manager should create it. This is next step.
| @@ -42,4 +45,7 @@ func (s *ServerOption) AddFlags(fs *flag.FlagSet) { | |||
| fs.StringVar(&s.KfVersion, "kubeflow-version", "v0.1.0-rc.4", "The Kubeflow version to use.") | |||
| fs.StringVar(&s.NameSpace, "namespace", "kubeflow", "The namespace where all resources for kubeflow will be created") | |||
| fs.BoolVar(&s.Apply, "apply", true, "Whether or not to apply the configuraiton.") | |||
| fs.StringVar(&s.Project, "project", "", "The GCP project where kubeflow will seat") | |||
There was a problem hiding this comment.
nit : The GCP project where kubeflow will be installed
|
/retest |
|
/assign @lluunn |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankushagarwal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* support IAP setup for bootstrap on GKE * handle review feedback
So user can manage secure login to Kubeflow with GCP account.
This will handle #665
This change is