-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(notebooks): correctly handle status.containerState
messages
#7585
fix(notebooks): correctly handle status.containerState
messages
#7585
Conversation
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
c7943a6
to
114eef0
Compare
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
status.containerState
messages
@kimwnasptd thanks for this, I fixed some typos in 4d70896. /lgtm I have merged most other pending PRs for 1.9.0 (see #7453), after this we should be good to cut a |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…beflow/kubeflow#7585) * common: Unpin gevent dependency Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * jwa(back): Better handling of message Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * jwa(back): Add unittests Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * fixup: Fix linting Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * fix typos Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> * fix tests Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> --------- Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
…beflow/kubeflow#7585) * common: Unpin gevent dependency Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * jwa(back): Better handling of message Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * jwa(back): Add unittests Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * fixup: Fix linting Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * fix typos Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> * fix tests Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> --------- Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
…beflow/kubeflow#7585) * common: Unpin gevent dependency Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * jwa(back): Better handling of message Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * jwa(back): Add unittests Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * fixup: Fix linting Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * fix typos Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> * fix tests Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> --------- Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
…beflow/kubeflow#7585) * common: Unpin gevent dependency Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * jwa(back): Better handling of message Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * jwa(back): Add unittests Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * fixup: Fix linting Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * fix typos Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> * fix tests Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> --------- Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
…beflow/kubeflow#7585) * common: Unpin gevent dependency Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * jwa(back): Better handling of message Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * jwa(back): Add unittests Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * fixup: Fix linting Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> * fix typos Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> * fix tests Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> --------- Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Fixes #7454
Update the backend code to gracefully handle the containerState and
message
, when it doesn't exist.I also unpinned the
gevent
package, since it introduces a CVE in all the web apps./cc @thesuperzapper