New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an examples package in kubeflow #768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
examples package is intended to contain self-contained prototypes for deploying tf-job, tf-serving, etc. The idea is that users should be able to fully customize and extend these prototypes by modifying the jsonnet Fixes #564
/retest |
}, | ||
spec: { | ||
template: { | ||
metadata: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lluunn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Create an examples package in kubeflow examples package is intended to contain self-contained prototypes for deploying tf-job, tf-serving, etc. The idea is that users should be able to fully customize and extend these prototypes by modifying the jsonnet Fixes kubeflow#564 * Sidecar inject = true
…ubeflow#768) * image gcr.io/kubeflow-images-public/centraldashboard:vmaster-gb1400446 * Image built from kubeflow/kubeflow@b1400446
examples package is intended to contain self-contained prototypes for
deploying tf-job, tf-serving, etc.
The idea is that users should be able to fully customize and extend
these prototypes by modifying the jsonnet
Fixes #564
This change is