Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an examples package in kubeflow #768

Merged
merged 2 commits into from May 10, 2018
Merged

Create an examples package in kubeflow #768

merged 2 commits into from May 10, 2018

Conversation

ankushagarwal
Copy link
Contributor

@ankushagarwal ankushagarwal commented May 7, 2018

examples package is intended to contain self-contained prototypes for
deploying tf-job, tf-serving, etc.

The idea is that users should be able to fully customize and extend
these prototypes by modifying the jsonnet

Fixes #564


This change is Reviewable

Copy link
Contributor

@kunmingg kunmingg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

examples package is intended to contain self-contained prototypes for
deploying tf-job, tf-serving, etc.

The idea is that users should be able to fully customize and extend
these prototypes by modifying the jsonnet

Fixes #564
@k8s-ci-robot k8s-ci-robot removed the lgtm label May 9, 2018
@ankushagarwal
Copy link
Contributor Author

/assign @kunmingg
/assign @lluunn

@ankushagarwal ankushagarwal changed the title [WIP] Create an examples package in kubeflow Create an examples package in kubeflow May 9, 2018
@ankushagarwal
Copy link
Contributor Author

/retest

},
spec: {
template: {
metadata: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@lluunn
Copy link
Contributor

lluunn commented May 10, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lluunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6e51786 into kubeflow:master May 10, 2018
@ankushagarwal ankushagarwal deleted the examples branch May 11, 2018 23:11
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* Create an examples package in kubeflow

examples package is intended to contain self-contained prototypes for
deploying tf-job, tf-serving, etc.

The idea is that users should be able to fully customize and extend
these prototypes by modifying the jsonnet

Fixes kubeflow#564

* Sidecar inject = true
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
…ubeflow#768)

* image gcr.io/kubeflow-images-public/centraldashboard:vmaster-gb1400446
* Image built from kubeflow/kubeflow@b1400446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants