Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in the README #77

Merged
merged 2 commits into from Jan 3, 2018
Merged

Fix a typo in the README #77

merged 2 commits into from Jan 3, 2018

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Jan 3, 2018

  • Originally this was Typo on #132 #67
  • I copied that PR in order to resolve out of date files.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@jlewi jlewi merged commit 2331d20 into kubeflow:master Jan 3, 2018
@jlewi jlewi mentioned this pull request Jan 3, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Nov 1, 2019
* fixes for basic-auth-ingress iap-ingress

* snapshot

* iap-ingress is missing parameters used in ksonnet

* updates per review

* update generated unit tests

* fixes for iap-ingress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants