Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use test_helper to simplify test_jsonnet.py #796

Merged
merged 1 commit into from May 14, 2018
Merged

Use test_helper to simplify test_jsonnet.py #796

merged 1 commit into from May 14, 2018

Conversation

ankushagarwal
Copy link
Contributor

@ankushagarwal ankushagarwal commented May 11, 2018

This change is Reviewable

@ankushagarwal ankushagarwal changed the title WIP Refactor testing Use test_helper to simplify test_jsonnet.py May 12, 2018
@lluunn
Copy link
Contributor

lluunn commented May 14, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lluunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6156203 into kubeflow:master May 14, 2018
@ankushagarwal ankushagarwal deleted the testing-refactor branch May 29, 2018 23:20
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants