Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAP should route to central ui instead of jupyterhub #827

Merged
merged 1 commit into from May 18, 2018

Conversation

kkasravi
Copy link
Contributor

@kkasravi kkasravi commented May 18, 2018

Fixes #809

  • Removed stanza in iap.libsonnet shown below
                        // TODO(ankushagarwal): We should eventually
                        // redirect to the central UI once its ready
                        // See https://github.com/kubeflow/kubeflow/pull/146
                        // Redirect to jupyterhub when visiting /
                        {
                          timeout_ms: 600000,
                          path: "/",
                          prefix_rewrite: "/hub",
                          use_websocket: true,
                          weighted_clusters: {
                            clusters: [
                              {
                                name: "cluster_jupyterhub",
                                weight: 100.0,
                              },
                            ],
                          },
                        },

This change is Reviewable

@kkasravi
Copy link
Contributor Author

/assign @ankushagarwal

@kkasravi
Copy link
Contributor Author

/cc @jlewi

@k8s-ci-robot k8s-ci-robot requested a review from jlewi May 18, 2018 11:18
@ankushagarwal
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankushagarwal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7e43810 into kubeflow:master May 18, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
* WIP

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* feat: support namespace for trial template

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Use configmap function

Signed-off-by: Ce Gao <gaoce@caicloud.io>
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IAP Envoy route should map / to central dashboard
3 participants