Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile override #84

Merged
merged 2 commits into from Jan 5, 2018
Merged

Makefile override #84

merged 2 commits into from Jan 5, 2018

Conversation

zomglings
Copy link
Contributor

  1. Simplified the image build and push process for model server (parametrized make invocation rather than having to manually update the Makefile).

  2. Added instructions for how to enable GCR from command line.

  3. Linked to more useful part of gcloud docs

@k8s-ci-robot
Copy link
Contributor

Hi @nkashy1. Thanks for your PR.

I'm waiting for a kubernetes or google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlewi jlewi merged commit 7b543ef into kubeflow:master Jan 5, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
* reduce build time

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* parallel build

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* fix

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants