New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a config map to configure bootstrapper. #859
Conversation
* Use deployment manager to create a config map containing a YAML spec that will be used to configure the ksonnet app created by the bootstrapper.
/assign @kunmingg |
command: | ||
- /opt/kubeflow/bootstrapper | ||
- --in-cluster | ||
- --namespace=kubeflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bootstrapper need config location:
--config=/etc/kubeflow/config.yaml
Thanks @kunmingg PTAL |
/lgtm |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Use a config map to configure bootstrapper. * Use deployment manager to create a config map containing a YAML spec that will be used to configure the ksonnet app created by the bootstrapper. * Address comments.
spec that will be used to configure the ksonnet app created by the
bootstrapper.
Related to #802 Trigger bootstrapper with deployment manager
This change is