Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tfjob(v1alpha2): Add validation #874

Merged
merged 2 commits into from Jun 4, 2018
Merged

tfjob(v1alpha2): Add validation #874

merged 2 commits into from Jun 4, 2018

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented May 25, 2018 •
edited by jlewi

/assign @jlewi

related to: kubeflow/training-operator#437

Signed-off-by: Ce Gao gaoce@caicloud.io

This change is Reviewable

jlewi
jlewi reviewed May 25, 2018
View reviewed changes
kubeflow/core/tf-job-operator.libsonnet Outdated
properties: {
replicas: {
type: "integer",
minimum: 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comment explaining why we set minimum to 1.
Also please add a comment explaining why the validation doesn't extend to the pod template spec.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will update it.

@gaocegege
Copy link
Member Author

PTAL

@gaocegege
Copy link
Member Author

/retest

@gaocegege
Copy link
Member Author

I do not think the failure is caused by this PR 🤔

@gaocegege
Copy link
Member Author

/retest

@jlewi
Copy link
Contributor

jlewi commented May 29, 2018

Yeah test failures look like flakes building the bootstrapper image.

@jlewi
Copy link
Contributor

jlewi commented May 29, 2018

/lgtm
/approve

@gaocegege
Copy link
Member Author

I am not sure when it will be fixed, could I retest the PR now?

@jlewi
Copy link
Contributor

jlewi commented Jun 1, 2018

/test all

@jlewi
Copy link
Contributor

jlewi commented Jun 1, 2018

@gaocegege The failure is a networking issue downloading kubectl. So in principal retrying immediately should work.

@gaocegege
Copy link
Member Author

/retest

@gaocegege
Copy link
Member Author

retest

@gaocegege
Copy link
Member Author

/retest

@gaocegege
Copy link
Member Author

I will rebase the master and have a try again.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jun 1, 2018
@ankushagarwal
Copy link
Contributor

#898 will hopefully fix the flaky test

@jlewi
Copy link
Contributor

jlewi commented Jun 1, 2018

@gaocegege Can you sync past #898 to see if that fixed the flakes?

@gaocegege
Copy link
Member Author

@jlewi OK, I will do it on Monday 😄

@gaocegege
tfjob(v1alpha2): Add validation
a829cfe 
Signed-off-by: Ce Gao <gaoce@caicloud.io>
@gaocegege
tf-job-operator: Add comments
dd2c524 
Signed-off-by: Ce Gao <gaoce@caicloud.io>
@gaocegege
Copy link
Member Author

PTAL @jlewi

The test is passed, thanks for your help @ankushagarwal

@jlewi
Copy link
Contributor

jlewi commented Jun 4, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f4cbffa into kubeflow:master Jun 4, 2018
wmuizelaar pushed a commit to bolcom/kubeflow that referenced this pull request Jun 5, 2018
@gaocegege @wmuizelaar
tfjob(v1alpha2): Add validation (kubeflow#874)
847c4fa 
* tfjob(v1alpha2): Add validation

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* tf-job-operator: Add comments

Signed-off-by: Ce Gao <gaoce@caicloud.io>
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
@gaocegege @k8s-ci-robot
tfjob(v1alpha2): Add validation (kubeflow#874)
a12ceb6 
* tfjob(v1alpha2): Add validation

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* tf-job-operator: Add comments

Signed-off-by: Ce Gao <gaoce@caicloud.io>
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
@kevinyu98
Update manifest readme (kubeflow#874)
269dcaf 
* fix the broken link for config

* update the readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewi jlewi jlewi left review comments

@jimexist jimexist Awaiting requested review from jimexist

@wbuchwalter wbuchwalter Awaiting requested review from wbuchwalter

Assignees

@jlewi jlewi

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gaocegege @jlewi @ankushagarwal @k8s-ci-robot