New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run v1alpha1 and v1alpha2 TfJob tests in GKE workflow #918
Run v1alpha1 and v1alpha2 TfJob tests in GKE workflow #918
Conversation
/retest |
1 similar comment
/retest |
/test all |
/retest |
3 similar comments
/retest |
/retest |
/retest |
This is ready for review Here is a sample run of this workflow : http://testing-argo.kubeflow.org/workflows/kubeflow-test-infra/kubeflow-presubmit-kubeflow-e2e-gke-918-d810986-2005-1454?tab=workflow |
Did you consider parameterizing the workflow by TFVersion and then submitting two different workflows? One for v1alpha1 and v1alpha2? |
Yes. That wasn't a clean approach either. A couple of problems in that approach:
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #852
This change is