Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run v1alpha1 and v1alpha2 TfJob tests in GKE workflow #918

Merged
merged 1 commit into from Jun 8, 2018
Merged

Run v1alpha1 and v1alpha2 TfJob tests in GKE workflow #918

merged 1 commit into from Jun 8, 2018

Conversation

ankushagarwal
Copy link
Contributor

@ankushagarwal ankushagarwal commented Jun 3, 2018

  • Update deploy_kubeflow_gcp to add tfjob_version flag
  • In GKE Testing workflow, bring up two k8s clusters - one to test v1alpha1 and other to test v1alpha2
  • Deploy kubeflow on both clusters using bootstrapper - set tfjob_version different for both clusters
  • Using different kubeConfig for both clusters
  • Teardown both clusters at the end

Fixes #852

This change is Reviewable

@ankushagarwal
Copy link
Contributor Author

/retest

1 similar comment
@ankushagarwal
Copy link
Contributor Author

/retest

@ankushagarwal
Copy link
Contributor Author

/test all

@ankushagarwal
Copy link
Contributor Author

/retest

3 similar comments
@ankushagarwal
Copy link
Contributor Author

/retest

@ankushagarwal
Copy link
Contributor Author

/retest

@ankushagarwal
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Jun 7, 2018
@ankushagarwal ankushagarwal changed the title WIP Don't Review - use v1alpha2 for TFJob Run v1alpha1 and v1alpha2 TfJob tests in GKE workflow Jun 7, 2018
@ankushagarwal
Copy link
Contributor Author

ankushagarwal commented Jun 7, 2018

@k8s-ci-robot k8s-ci-robot requested a review from jlewi June 7, 2018 22:59
@jlewi
Copy link
Contributor

jlewi commented Jun 8, 2018

Did you consider parameterizing the workflow by TFVersion and then submitting two different workflows? One for v1alpha1 and v1alpha2?

@ankushagarwal
Copy link
Contributor Author

Yes. That wasn't a clean approach either. A couple of problems in that approach:

  1. Tests would be repeated - pytorchjob tests, jsonnet tests - needed to add logic to skip tests
  2. The workflow copies all the junit-xml files to a common artifacts directory at the end of the test. Running multiple copies of the test would cause the artifacts to be overridden - we would have to add logic to create files with different names for each of the workflow steps

@jlewi
Copy link
Contributor

jlewi commented Jun 8, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f7d4470 into kubeflow:master Jun 8, 2018
@ankushagarwal ankushagarwal deleted the e2etest-v1alpha2-v1alpha2 branch June 13, 2018 17:30
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants