Source admin role should be granted to KF service accounts. #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankushagarwal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
* Source admin permission was granted to cloud services account but that service account is only used by deployment manager and shouldn't need source admin. * We want the Kubeflow service accounts to have access to source admin so that we can push the ksonnet app to source control and so that users can access their code in pods.
|
/test all |
|
@ankushagarwal Could you re-lgtm please? I needed to sync to get tests to pass. |
|
/lgtm |
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
…#965) * Source admin permission was granted to cloud services account but that service account is only used by deployment manager and shouldn't need source admin. * We want the Kubeflow service accounts to have access to source admin so that we can push the ksonnet app to source control and so that users can access their code in pods.
yanniszark
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source admin permission was granted to cloud services account but
that service account is only used by deployment manager and shouldn't
need source admin.
We want the Kubeflow service accounts to have access to source admin
so that we can push the ksonnet app to source control and so that users
can access their code in pods.
/assign @ankushagarwal
This change is