Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable iam api and set project flag explicitly #993

Merged
merged 1 commit into from Jun 13, 2018
Merged

Enable iam api and set project flag explicitly #993

merged 1 commit into from Jun 13, 2018

Conversation

ankushagarwal
Copy link
Contributor

@ankushagarwal ankushagarwal commented Jun 13, 2018

Also, use set +e to disable exit on error for bash

/cc @activatedgeek @kunmingg


This change is Reviewable

Also, use set +e to disable exit on error for bash
@kunmingg
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kunmingg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f637740 into kubeflow:master Jun 13, 2018
@ankushagarwal ankushagarwal deleted the deploy.sh-fixes branch June 14, 2018 16:32
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
Also, use set +e to disable exit on error for bash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants