Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC EnvoyFilter not working with Istio 1.3.1 #1115

Closed
adriangonz opened this issue Apr 17, 2020 · 5 comments
Closed

OIDC EnvoyFilter not working with Istio 1.3.1 #1115

adriangonz opened this issue Apr 17, 2020 · 5 comments

Comments

@adriangonz
Copy link
Member

Describe the bug:

I'm currently trying to set up a cluster with Istio and Dex using Istio 1.3.1 instead of Istio 1.1.6 (using the manifests under istio-1-3-1). However, I can't get the login flow to work. In particular what I see is that the /login/oidc URL just returns a 404 error. On a regular cluster (i.e. using Istio 1.1.6) /login/oidc would just get routed to the authservice pod.

Potential cause:

The routing of /login/oidc requests to the authservice seems to happen through an EnvoyFilter created in istio/oidc-authservice. However, Istio 1.3 released some changes affecting the EnvoyFilter CRD. This means that the manifests for Istio 1.3.1 (under istio-1-3-1) are currently incompatible with the ones under istio/oidc-authservice.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/question 0.61

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@kubeflow-bot kubeflow-bot added this to To Do in Needs Triage Apr 17, 2020
@adriangonz
Copy link
Member Author

/kind bug

@jtfogarty
Copy link

/area istio

@jtfogarty jtfogarty moved this from To Do to Assigned to Area Owner For Triage in Needs Triage Apr 17, 2020
@kubeflow-bot kubeflow-bot removed this from Assigned to Area Owner For Triage in Needs Triage Apr 17, 2020
@yanniszark
Copy link
Contributor

Hi @adriangonz!
We have been deploying clusters with Istio 1.3.1 and that exact EnvoyFilter for a while now.
In fact, the last MiniKF has Istio 1.3.1 and uses that EnvoyFilter.
The kfctl_istio_dex config uses Istio 1.3.1 by default. Did you make any changes to the KFDef file before deploying?
Can you include your KFDef file here?

@adriangonz
Copy link
Member Author

I think you are on the money @yanniszark. I was tinkering with the kfctl_istio_dex config and it seems I may have removed something important. Using the default one with Istio 1.3.1 seems to work!

Closing this issue now as there doesn't seem to be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants