Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step 2: Move manifests development upstream #1740

Closed
yanniszark opened this issue Feb 9, 2021 · 3 comments
Closed

Step 2: Move manifests development upstream #1740

yanniszark opened this issue Feb 9, 2021 · 3 comments

Comments

@yanniszark
Copy link
Contributor

yanniszark commented Feb 9, 2021

Part-of: #1735
Depends-on: #1738

Background

As part of the work of wg-manifests for 1.3 (#1735), we are moving manifests development in upstream repos. This is the second step of our plan for 1.3.

Current State

Applications have manifests in two places:

  • In their upstream repos.
  • In the manifests repo.

This is a table of every KF app in manifests, along with its upstream repo and the folder in the upstream repo where authors currently store manifests:

Application Manifests Path Upstream Path Upstream Repo
TFJob Operator apps/tf-training/upstream manifests https://github.com/kubeflow/tf-operator
PyTorch Operator apps/pytorch-job/upstream manifests https://github.com/kubeflow/pytorch-operator
MPI Operator apps/mpi-job/upstream manifests https://github.com/kubeflow/mpi-operator
MXNet Operator apps/mxnet-job/upstream manifests https://github.com/kubeflow/mxnet-operator
XGBoost Operator apps/xgboost-job/upstream manifests https://github.com/kubeflow/xgboost-operator
Kubebench apps/kubebench/upstream manifests https://github.com/kubeflow/kubebench
Notebook Controller apps/jupyter/notebook-controller/upstream components/notebook-controller/config https://github.com/kubeflow/kubeflow
Central Dashboard apps/centraldashboard/upstream components/centraldashboard/manifests https://github.com/kubeflow/kubeflow
Profiles + KFAM apps/profiles/upstream components/profile-controller/config https://github.com/kubeflow/kubeflow
PodDefaults Webhook apps/admission-webhook/upstream components/admission-webhook/manifests https://github.com/kubeflow/kubeflow
Jupyter Web App apps/jupyter/jupyter-web-app/upstream components/crud-web-apps/jupyter/manifests https://github.com/kubeflow/kubeflow
Katib apps/katib/upstream manifests/v1beta1 https://github.com/kubeflow/katib
KFServing apps/kfserving/upstream config https://github.com/kubeflow/kfserving
Kubeflow Pipelines apps/pipeline/upstream manifests/kustomize https://github.com/kubeflow/pipelines

Desired State

Consolidate all manifests development in the upstream repo. The manifests repo will include a copy of the manifests under the relevant folder.

@yanniszark
Copy link
Contributor Author

yanniszark commented Feb 10, 2021

I will use the following table to track the progress of issues / PRs:

Application WG Issue PR Merged
TFJob Operator kubeflow/wg-training-leads kubeflow/training-operator#1246 kubeflow/training-operator#1247 ✔️
PyTorch Operator kubeflow/wg-training-leads kubeflow/pytorch-operator#318 kubeflow/pytorch-operator#320 ✔️
MPI Operator kubeflow/wg-training-leads kubeflow/mpi-operator#325 kubeflow/mpi-operator#326 ✔️
MXNet Operator kubeflow/wg-training-leads kubeflow/mxnet-operator#88 kubeflow/mxnet-operator#90 ✔️
XGBoost Operator kubeflow/wg-training-leads kubeflow/xgboost-operator#109 kubeflow/xgboost-operator#110 ✔️
Kubebench kubeflow/wg-training-leads kubeflow/kubebench#216 kubeflow/kubebench#217
Notebook Controller kubeflow/wg-notebooks-leads kubeflow/kubeflow#5592 kubeflow/kubeflow#5608 ✔️
Central Dashboard kubeflow/wg-notebooks-leads kubeflow/kubeflow#5594 kubeflow/kubeflow#5609 ✔️
Profiles + KFAM kubeflow/wg-notebooks-leads kubeflow/kubeflow#5595 kubeflow/kubeflow#5611 ✔️
PodDefaults Webhook kubeflow/wg-notebooks-leads kubeflow/kubeflow#5596 kubeflow/kubeflow#5612 ✔️
Jupyter Web App kubeflow/wg-notebooks-leads kubeflow/kubeflow#5593 kubeflow/kubeflow#5613 ✔️
Katib kubeflow/wg-automl-leads kubeflow/katib#1431 kubeflow/katib#1432 ✔️
KFServing kubeflow/wg-serving-leads kserve/kserve#1376 kserve/kserve#1424 ✔️
Kubeflow Pipelines kubeflow/wg-pipeline-leads kubeflow/pipelines#5133 kubeflow/pipelines#5256 ✔️

@juliusvonkohout
Copy link
Member

@yanniszark i noticed that e.g. https://github.com/kubeflow/manifests/tree/master/apps/pipeline/upstream/mysql/base is a bit outdated compared to the real upstream manifests. Will you update all manifestes before the 1.3 release or link on the filesystem level to the upstream repositories?

@yanniszark
Copy link
Contributor Author

@juliusvonkohout exactly, please follow this issue for the work of syncing manifests:
#1775

Closing this issue as it is complete

Needs Triage automation moved this from To Do to Closed Mar 23, 2021
@kubeflow-bot kubeflow-bot removed this from Closed in Needs Triage Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants