Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pipeline version to 0.2.5 in v1.0-branch #984

Closed
Jeffwan opened this issue Mar 4, 2020 · 12 comments · Fixed by #1083 or #1093
Closed

Bump pipeline version to 0.2.5 in v1.0-branch #984

Jeffwan opened this issue Mar 4, 2020 · 12 comments · Fixed by #1083 or #1093

Comments

@Jeffwan
Copy link
Member

Jeffwan commented Mar 4, 2020

Pipeline version in Kubeflow v1.0 is 0.2.0 which has been released for 2 months.
I suggest to bump the version to 0.2.5 in v1.0-branch as it contains some performance critical improvements.

Examples:
kubeflow/pipelines#3165

/cc @richardsliu @Bobgy @Ark-kun

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
feature 0.66

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@kubeflow-bot kubeflow-bot added this to To Do in Needs Triage Mar 4, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Mar 5, 2020

Yep, I think we should do this. I'd like to know others' opinions too.

Related issues include

@Jeffwan
Copy link
Member Author

Jeffwan commented Mar 6, 2020

Hi @Bobgy, Not sure any compatibility concerns to use 0.2.5 in v1.0-branch? I think the plan could be use 0.2.5 is master, run some manual tests and if cherry-pick back to v1.0-branch?

@Bobgy
Copy link
Contributor

Bobgy commented Mar 9, 2020

I don't think there are any compatibility issues, KFP has been backward compatible from 0.2.0 to 0.2.5

@Jeffwan
Copy link
Member Author

Jeffwan commented Mar 10, 2020

@Bobgy Cool, thanks for the confirmation. Kindly ping @Ark-kun @rmgogogo for their feedbacks

@Bobgy
Copy link
Contributor

Bobgy commented Mar 17, 2020

@Ark-kun @rmgogogo pinging again

@elikatsis
Copy link
Member

This (important) issue is also resolved in KFP>0.2.0 (included in release 0.2.1): kubeflow/pipelines#2764

@Bobgy
Copy link
Contributor

Bobgy commented Mar 25, 2020

I'd like to send a PR to update KFP to 0.3.0 instead, because we'd make sure kfp is not broken due to kubeflow/kfctl#131.

KFP 0.3.0 included the fix: kubeflow/pipelines#3305

@Bobgy
Copy link
Contributor

Bobgy commented Mar 25, 2020

I didn't see this issue is about v1.0-branch. Actually I only intended to upgrade to 0.3.0 in master branch, because it was not as heavily tested as 0.2.5. I'd still recommend 0.2.5 for v1.0-branch.

@Jeffwan
Copy link
Member Author

Jeffwan commented Mar 25, 2020

We need to discuss whether we like to cut v1.1-branch. If it's coming soon, it's fine to leave v1.0-branch with existing version

@Bobgy
Copy link
Contributor

Bobgy commented Mar 25, 2020

@Jeffwan Jeremey mentioned v1.1 is targeted for June, so looks like updating v1.0-branch will be the best option now.

kubeflow/pipelines#1223 (comment)

@apryiomka
Copy link

Do we know when this might be merged to Kubeflow v1.0.2 manifest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants