This repository has been archived by the owner on Dec 2, 2021. It is now read-only.
[MLMD Lineage] Style changes to scale view for normal laptop screens #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avdaredevil
changed the title
|
Looks great! Do you know what the test failure is? The argo console doesn't show anything for me. /lgtm |
kwasi
approved these changes
Jan 7, 2020
|
/retest |
Merged
avdaredevil
force-pushed
the
lineage-scale
branch
from
9404210
to
1e4b622
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwasi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
avdaredevil
force-pushed
the
lineage-scale
branch
from
1e4b622
to
c4aeac9
Compare
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #193
fixes #195
About
Changes to make the lineage view fit on a normal laptop screen:
Also updated CSS to show Mac-style scrollbars at all times.
Image
Meta
/area metadata
/area front-end
/priority p1
/assign @avdaredevil
/cc @kwasi
This change is